Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0-rc2] [wasm] Download Symbols from microsoft symbol server #42260

Closed
wants to merge 22 commits into from
Closed

[release/5.0-rc2] [wasm] Download Symbols from microsoft symbol server #42260

wants to merge 22 commits into from

Commits on Sep 15, 2020

  1. Creating a draft to download symbols from microsoft symbol server whe… 

    …n there is an exception and exceptions are turned on on debugger. This is a workaround while VS doesn't work on it, which should be the final solution.
    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    698bb0d View commit details
    Browse the repository at this point in the history

  2. Fix what lewing suggested.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    50e7d08 View commit details
    Browse the repository at this point in the history

  3. Changing what @radical suggested.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    0ffcf9b View commit details
    Browse the repository at this point in the history

  4. Changed what @radical suggested.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    6107b2d View commit details
    Browse the repository at this point in the history

  5. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    2 people authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    4dab8bc View commit details
    Browse the repository at this point in the history

  6. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    2 people authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    43cc04a View commit details
    Browse the repository at this point in the history

  7. If it's not available on a URL try in the next one in the list.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    0c7b10c View commit details
    Browse the repository at this point in the history

  8. Logging error and adding comment about SDSR

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    c8d7742 View commit details
    Browse the repository at this point in the history

  9. Returning if we find the method even if we have an exception sending … 

    …files to browser.
    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    18d6208 View commit details
    Browse the repository at this point in the history

  10. Logging when we don't find the pdb.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    ea51e4e View commit details
    Browse the repository at this point in the history

  11. Changing what @radical suggested.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    0d4854d View commit details
    Browse the repository at this point in the history

  12. Avoiding that we try to load symbols from the same assembly more than… 

    … once.
    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e779ea2 View commit details
    Browse the repository at this point in the history

  13. Simplifying and adding more log.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    d578ca6 View commit details
    Browse the repository at this point in the history

  14. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    @thaystg @lewing
    2 people authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    51cc013 View commit details
    Browse the repository at this point in the history

  15. Adding support for receive the urlSymbolServer as a parameter in the … 

    …request as discussed with Diego:

Diego: The response from vs code is that this shouldn't live in js-debug, so I think that passing it around in inspectUri would be the best approach for us
    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    8b75a9e View commit details
    Browse the repository at this point in the history

  16. Fix @radical suggestion.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5184f7a View commit details
    Browse the repository at this point in the history

  17. Removing default symbol server URL, like this we can land this on rc … 

    …5.0 without any risk of side effect.
    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    1460ce8 View commit details
    Browse the repository at this point in the history

  18. Fix compilation.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    ec1661d View commit details
    Browse the repository at this point in the history

  19. Update src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessStartup.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    2 people authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    b9c5f30 View commit details
    Browse the repository at this point in the history

  20. Update src/mono/wasm/debugger/BrowserDebugHost/Startup.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    2 people authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    31465a9 View commit details
    Browse the repository at this point in the history

  21. Accepting @radical suggestion.

    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    91d6f1b View commit details
    Browse the repository at this point in the history

  22. Adding workaround on dotnet/runtime while PR 686 is not merged on Cec… 

    …il. When it's merged we will not get any side effect with this workaroud.
    @thaystg
    thaystg authored and github-actions committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    48879da View commit details
    Browse the repository at this point in the history