[release/5.0-rc2] [wasm] Download Symbols from microsoft symbol server #42260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…n there is an exception and exceptions are turned on on debugger. This is a workaround while VS doesn't work on it, which should be the final solution.
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
…files to browser.
Co-authored-by: Larry Ewing <lewing@microsoft.com>
…request as discussed with Diego: Diego: The response from vs code is that this shouldn't live in js-debug, so I think that passing it around in inspectUri would be the best approach for us
…5.0 without any risk of side effect.
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
…il. When it's merged we will not get any side effect with this workaroud.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @thaystg |
|
@danroth27 is this important enough for you to land before GA? |
|
We've discussed this and we are trying to come up with a broader plan for settings like this that cooperate with other tooling. That said, I think it is safe to take if we want it in. |
|
This seems low risk and valuable functionality to take into .NET 5. I'm supportive of taking this. |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/280022283 |
|
@marek-safar backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Creating a draft to download symbols from microsoft symbol server when there is an exception and exceptions are turned on on debugger. This is a workaround while VS doesn't work on it, which should be the final solution.
.git/rebase-apply/patch:14: trailing whitespace.
.git/rebase-apply/patch:125: trailing whitespace.
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
M src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Falling back to patching base and 3-way merge...
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Auto-merging src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs
Applying: Fix what lewing suggested.
Applying: Changing what @radical suggested.
Applying: Changed what @radical suggested.
Applying: Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Applying: Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Applying: If it's not available on a URL try in the next one in the list.
Applying: Logging error and adding comment about SDSR
Applying: Returning if we find the method even if we have an exception sending files to browser.
Applying: Logging when we don't find the pdb.
Applying: Changing what @radical suggested.
Applying: Avoiding that we try to load symbols from the same assembly more than once.
Applying: Simplifying and adding more log.
Applying: Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Applying: Adding support for receive the urlSymbolServer as a parameter in the request as discussed with Diego:
error: sha1 information is lacking or useless (src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0015 Adding support for receive the urlSymbolServer as a parameter in the request as discussed with Diego:
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@marek-safar should I do the backport manually? |
|
closing because this targets rc2 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40690 to release/5.0-rc2
/cc @thaystg
Customer Impact
When a customer is trying to debug aspnetcore assemblies the pdb info can be found on MS Symbol Server, with this PR we try to find it, if it's configured on inspectURI on launchSettings.json :
"inspectUri": "{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}?urlSymbolServer=http://msdl.microsoft.com/download/symbols".Fixes #39969 and #39450
Testing
I test locally adding and removing the parameter on VSWin.
Risk
No risk, if the user does not pass any extra parameter on inspectUri, this will not have any effect.