[release/5.0] [wasm] Download Symbols from microsoft symbol server #42901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg |
marek-safar
changed the title
marek-safar
approved these changes
Oct 2, 2020
marek-safar
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40690 to release/5.0-rc
/cc @thaystg
Customer Impact
When a customer is trying to debug aspnetcore assemblies the pdb info can be found on MS Symbol Server, with this PR we try to find it, if it's configured on inspectURI on launchSettings.json :
"inspectUri": "{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}?urlSymbolServer=http://msdl.microsoft.com/download/symbols".Fixes #39969 and #39450
Testing
I test locally adding and removing the parameter on VSWin.
Risk
No risk, if the user does not pass any extra parameter on inspectUri, this will not have any effect.