[release/5.0] Fixed compilation for libicu 68. (#47352) #49460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsPort of: #47352 This is to unblock osx builds now that brew is installing icu 68 by default. cc: @danmoseley
|
hoyosjs
approved these changes
Mar 10, 2021
jkotas
approved these changes
Mar 10, 2021
tarekgh
approved these changes
Mar 10, 2021
|
@danmoseley @mmitche @Anipik is it OK to merge this to unblock builds? |
Go for it. |
|
thanks for asking, but you don't need permission from me to merge a fix to the build 🙂 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of: #47352
This is to unblock osx builds now that brew is installing icu 68 by default.
cc: @danmoseley