Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable some Android Globalization tests #56147

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

steveisok
Copy link
Member

Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.

Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.

Fixes #36672

Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures.  This change skips the data items that do have difficulty.

Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop.  Adjusted accordingly.

Fixes dotnet#36672
@ghost
Copy link

ghost commented Jul 22, 2021

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.

Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.

Fixes #36672

Author: steveisok
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@MaximLipnin
Copy link
Contributor

Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.

Will we have to do anything with it or is it just a fact?

@ghost
Copy link

ghost commented Jul 22, 2021

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.

Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.

Fixes #36672

Author: steveisok
Assignees: -
Labels:

area-System.Globalization, os-android

Milestone: -

@tarekgh tarekgh added this to the 6.0.0 milestone Jul 22, 2021
@steveisok
Copy link
Member Author

Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.

Will we have to do anything with it or is it just a fact?

I think it's just something we'll have to live with. We aren't in control of the ICU library used and how the data may have been shaped.

@tarekgh
Copy link
Member

tarekgh commented Jul 22, 2021

That is a surprising behavior to me. What happen if the user set the default user language on Android to Turkish? would still get this behavior?

@steveisok
Copy link
Member Author

That is a surprising behavior to me. What happen if the user set the default user language on Android to Turkish? would still get this behavior?

I changed the language and there was no difference in the test results.

@steveisok steveisok merged commit 4e47e8c into dotnet:main Jul 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Globalization.Tests fail on Android
3 participants