-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable some Android Globalization tests #56147
Reenable some Android Globalization tests #56147
Conversation
Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty. Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly. Fixes dotnet#36672
Tagging subscribers to this area: @tarekgh, @safern Issue DetailsAndroid ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty. Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly. Fixes #36672
|
Will we have to do anything with it or is it just a fact? |
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsAndroid ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty. Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly. Fixes #36672
|
I think it's just something we'll have to live with. We aren't in control of the ICU library used and how the data may have been shaped. |
That is a surprising behavior to me. What happen if the user set the default user language on Android to Turkish? would still get this behavior? |
I changed the language and there was no difference in the test results. |
Android ICU seems to have slight behavioral differences with Turkish and Slovak cultures. This change skips the data items that do have difficulty.
Additionally, there are a few other tests that were failing because the test data should have been the same as what we use on desktop. Adjusted accordingly.
Fixes #36672