[release/6.0-preview7] [loader] Call managed resolving events for the default ALC #56421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Refine the work in f70b5b7 The issue is that even if we know that the ALC gchandle points to null in native, we can't automatically skip the call to the managed resolving event (for native library, for example) because the native event is indirectly responsible for creating the default ALC managed object. Instead, check in native if the gchandle is equal to the default ALC's gchandle (which is initially allocated with a null target) and if so pass IntPtr.Zero to the managed code, which will call `AssemblyLoadContext.GEtAssemblyLoadContext (IntPtr gch)` which in turn will construct the managed object for the default ALC. Fixes #55921
github-actions
bot
requested review from
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: Issue DetailsBackport of #56398 to release/6.0-preview7 /cc @lambdageek Customer ImpactTestingRisk
|
|
I don't think we can take this change as it's too late for P7. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #56398 to release/6.0-preview7
/cc @lambdageek
Customer Impact
Code using assembly load contexts will get a null reference exception when accessing the default ALC.
Testing
Manual testing.
Risk
Moderate. This is changing some code that runs early during app startup. On Android, the embedder host uses the mono API to add hooks that run when managed and native libraries are loaded. This PR could cause those hooks to behave differently, potentially leading to crashes at startup. However it should fail in pretty much every CI test in Xamarin.Android, so a mistake should be easily detectable.