Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0-preview7] [loader] Call managed resolving events for the default ALC #56421

Closed
wants to merge 2 commits into from
Closed

[release/6.0-preview7] [loader] Call managed resolving events for the default ALC #56421

wants to merge 2 commits into from

Commits on Jul 27, 2021

  1. [loader] Call managed resolving events for the default ALC 

    Refine the work in
f70b5b7

The issue is that even if we know that the ALC gchandle points to null in
native, we can't automatically skip the call to the managed resolving
event (for native library, for example) because the native event is indirectly
responsible for creating the default ALC managed object.

Instead, check in native if the gchandle is equal to the default ALC's
gchandle (which is initially allocated with a null target) and if so pass
IntPtr.Zero to the managed code, which will call
`AssemblyLoadContext.GEtAssemblyLoadContext (IntPtr gch)` which in turn will
construct the managed object for the default ALC.

Fixes #55921
    @lambdageek
    lambdageek authored and github-actions committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    c356875 View commit details
    Browse the repository at this point in the history

  2. remove one more early exit

    @lambdageek
    lambdageek authored and github-actions committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    70fd153 View commit details
    Browse the repository at this point in the history