[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

mdh1418 · 2021-07-30T14:50:56Z

It was confirmed that System.Net.Requests no longer fails for System.IO.DirectoryNotFoundException.
However, the tests still crash due to an assert error with System.Net.Http.AuthenticationHelper.SendWithAuthAsync.

By not defaulting preauthenticate parameter in SendWithRequestAuthAsync call in InnerSendAsync of AuthenticationHelper.NtAuth.tvOS.cs to true, the assert error no longer crashes tests.

Fixes #56621

Instead, now there are failures with regards to

System.Net.Requests.Tests.dll   Failed: 8

Test collection for System.Net.Tests.HttpWebRequestTest_Sync
System.Net.Tests.HttpWebRequestTest_Sync.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Sync.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415))\n-------- System.Net.WebException : Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415)\n------------ System.Net.Http.HttpRequestException : Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415)\n---------------- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Operation timed out [::ffff:127.0.0.1]:50415\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Sync.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Sync.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515))\n-------- System.Net.WebException : Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515)\n------------ System.Net.Http.HttpRequestException : Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515)\n---------------- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Operation timed out [::ffff:127.0.0.1]:50515\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header

Test collection for System.Net.Tests.HttpWebRequestTest_Async
System.Net.Tests.HttpWebRequestTest_Async.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Async.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out (127.0.0.1:50645))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out (127.0.0.1:50645))\n-------- System.Net.WebException : Operation timed out (127.0.0.1:50645)\n------------ System.Net.Http.HttpRequestException : Operation timed out (127.0.0.1:50645)\n---------------- System.Net.Sockets.SocketException : Operation timed out\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Async.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Async.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out (127.0.0.1:50739))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out (127.0.0.1:50739))\n-------- System.Net.WebException : Operation timed out (127.0.0.1:50739)\n------------ System.Net.Http.HttpRequestException : Operation timed out (127.0.0.1:50739)\n---------------- System.Net.Sockets.SocketException : Operation timed out\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header

This PR does the following:
Modifies the default authentication parameters in AuthenticationHelper.NtAuth.tvOS.cs
Removes the test suite project level skip
Adds active issues to the two failing tests for tvOS #56798
Conditions two tests that fail for BinaryFormatter not supported reasons.

filipnavara · 2021-07-30T14:53:17Z

However, the tests still crash due to an assert error with System.Net.Http.AuthenticationHelper.SendWithAuthAsync.

Do you have link to the failed test run? Is it happening on both iOS and tvOS, or only on tvOS? (the code path is different due to lack of NT authentication on tvOS)

mdh1418 · 2021-07-30T14:56:33Z

It was ran locally and crashed #56621
It was only happening on tvOS it seems. I just ran iOS and will update this and the issue accordingly. iOS only fails with binary formatter PNSE which I think I will address in another PR.

filipnavara · 2021-07-30T15:16:36Z

That seems to be a genuine bug on these lines:

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.tvOS.cs

Lines 15 to 16 in 03211e3

    
           SendWithProxyAuthAsync(request, authUri, async, credentials, true, connectionPool, cancellationToken).AsTask() : 
        
           SendWithRequestAuthAsync(request, async, credentials, true, connectionPool, cancellationToken).AsTask();

The preauthenticate parameter should be false instead of true. It may need some further tweaking but always sending true is definitely wrong.

...s/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.tvOS.cs

mdh1418 · 2021-08-03T19:45:51Z

Re:

System.Net.Requests.Tests.dll   Failed: 8

Test collection for System.Net.Tests.HttpWebRequestTest_Sync
System.Net.Tests.HttpWebRequestTest_Sync.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Sync.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415))\n-------- System.Net.WebException : Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415)\n------------ System.Net.Http.HttpRequestException : Operation timed out [::ffff:127.0.0.1]:50415 (127.0.0.1:50415)\n---------------- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Operation timed out [::ffff:127.0.0.1]:50415\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Sync.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Sync.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515))\n-------- System.Net.WebException : Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515)\n------------ System.Net.Http.HttpRequestException : Operation timed out [::ffff:127.0.0.1]:50515 (127.0.0.1:50515)\n---------------- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Operation timed out [::ffff:127.0.0.1]:50515\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header

Test collection for System.Net.Tests.HttpWebRequestTest_Async
System.Net.Tests.HttpWebRequestTest_Async.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Async.GetResponseAsync_UseDefaultCredentials_ExpectSuccess(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out (127.0.0.1:50645))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out (127.0.0.1:50645))\n-------- System.Net.WebException : Operation timed out (127.0.0.1:50645)\n------------ System.Net.Http.HttpRequestException : Operation timed out (127.0.0.1:50645)\n---------------- System.Net.Sockets.SocketException : Operation timed out\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Async.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: True)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (The operation has timed out.)) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (The operation has timed out.)\n-------- System.Net.WebException : The operation has timed out.\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header
System.Net.Tests.HttpWebRequestTest_Async.HaveResponse_GetResponseAsync_ExpectTrue(useSsl: False)
    System.AggregateException : One or more errors occurred. (One or more errors occurred. (Operation timed out (127.0.0.1:50739))) (One or more errors occurred. (Unexpected EOF trying to read request header))\n---- System.AggregateException : One or more errors occurred. (Operation timed out (127.0.0.1:50739))\n-------- System.Net.WebException : Operation timed out (127.0.0.1:50739)\n------------ System.Net.Http.HttpRequestException : Operation timed out (127.0.0.1:50739)\n---------------- System.Net.Sockets.SocketException : Operation timed out\n---- System.AggregateException : One or more errors occurred. (Unexpected EOF trying to read request header)\n-------- System.IO.IOException : Unexpected EOF trying to read request header

I'm not sure where tvOS and iOS are differing since the iOS tests pass.
From the stack trace, it looks like

at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in System.Net.Requests.Tests.dll:token 0x6000065+0x247
   at System.Net.Test.Common.LoopbackServer.<>c__DisplayClass15_0.<<CreateClientAndServerAsync>b__0>d.MoveNext() in System.Net.Requests.Tests.dll:token 0x60005e7+0xc4
--- End of stack trace from previous location ---
   at System.Net.Test.Common.LoopbackServer.CreateServerAsync(Func`2 funcAsync, Options options) in System.Net.Requests.Tests.dll:token 0x6000079+0x104
   at System.Net.Tests.HttpWebRequestTest.HaveResponse_GetResponseAsync_ExpectTrue(Boolean useSsl) in System.Net.Requests.Tests.dll:token 0x6000146+0xb4
--- End of stack trace from previous location ---
----- Inner Stack Trace #1 (System.AggregateException) -----
----- Inner Stack Trace -----
   at System.Net.HttpWebRequest.GetResponse() in System.Net.Requests.dll:token 0x6000124+0x2c
   at System.Net.Tests.HttpWebRequestTest_Sync.<>c__DisplayClass1_0.<GetResponseAsync>b__0() in System.Net.Requests.Tests.dll:token 0x60002c1+0x0
   at System.Threading.Tasks.Task`1[[System.Net.WebResponse, System.Net.Requests, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a]].InnerInvoke() in System.Private.CoreLib.dll:token 0x60033a3+0x25
   at System.Threading.Tasks.Task.<>c.<.cctor>b__271_0(Object obj) in System.Private.CoreLib.dll:token 0x6003544+0x16
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state) in System.Private.CoreLib.dll:token 0x6003002+0x36
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state) in System.Private.CoreLib.dll:token 0x6003002+0x79
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) in System.Private.CoreLib.dll:token 0x600349e+0xd3
--- End of stack trace from previous location ---
   at System.Net.Tests.HttpWebRequestTest.<HaveResponse_GetResponseAsync_ExpectTrue>b__118_0(Uri uri) in System.Net.Requests.Tests.dll:token 0x6000170+0xbe
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in System.Net.Requests.Tests.dll:token 0x6000065+0x13e
----- Inner Stack Trace #2 (System.AggregateException) -----
----- Inner Stack Trace -----
   at System.Net.Test.Common.LoopbackServer.Connection.ReadRequestHeaderBytesAsync() in System.Net.Requests.Tests.dll:token 0x600026c+0xf0
   at System.Net.Test.Common.LoopbackServer.Connection.ReadRequestDataAsync(Boolean readBody) in System.Net.Requests.Tests.dll:token 0x6000274+0x8c
   at System.Net.Test.Common.LoopbackServer.Connection.HandleRequestAsync(HttpStatusCode statusCode, IList`1 headers, String content) in System.Net.Requests.Tests.dll:token 0x600027d+0x82
   at System.Net.Test.Common.LoopbackServer.HandleRequestAsync(HttpStatusCode statusCode, IList`1 headers, String content) in System.Net.Requests.Tests.dll:token 0x600008c+0x125
   at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks) in System.Net.Requests.Tests.dll:token 0x6000065+0x90

So ReadLineBytesAsync is called by ReadRequestHeaderBytesAsync and there must be something going wrong with reading the bytes

… failure

[libraries][iOS][tvOS] Update Issue causing System.Net.Requests to fail

6ca5bc9

mdh1418 requested review from steveisok, MaximLipnin, filipnavara and marek-safar July 30, 2021 14:51

mdh1418 changed the title ~~[libraries][iOS][tvOS] Update Issue causing System.Net.Requests to fail~~ [libraries][tvOS] Update Issue causing System.Net.Requests to fail Jul 30, 2021

[libraries][tvOS] Default preauthenticate in InnerSendAsync to false

5a1d580

filipnavara reviewed Aug 3, 2021

View reviewed changes

...s/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.tvOS.cs Outdated Show resolved Hide resolved

Mitchell Hwang added 2 commits August 3, 2021 14:04

Defalt SendWithProxyAuthAsync doRequestAuth parameter to false

4f83399

[libraries] Add IsBinaryFormatterSupported ConditionalFact

9c5cdc3

mdh1418 mentioned this pull request Aug 3, 2021

Unexpected EOF trying to read request header LoopbackServer #56798

Closed

Mitchell Hwang added 2 commits August 3, 2021 16:27

[libraries][tvOS] Add ActiveIssue for loopback request header reading…

6221e2f

… failure

Fix location of ActiveIssue

0e660d6

steveisok approved these changes Aug 6, 2021

View reviewed changes

mdh1418 merged commit 7a4aa2e into dotnet:main Aug 6, 2021

mdh1418 deleted the ios_tvos_system_net_requests_migrate_issue branch August 6, 2021 13:19

jaredpar mentioned this pull request Aug 17, 2021

RunContinueWithStressTestsNoState timing out in CI #2271

Closed

ghost locked as resolved and limited conversation to collaborators Sep 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

mdh1418 commented Jul 30, 2021 •

edited

Loading

filipnavara commented Jul 30, 2021

mdh1418 commented Jul 30, 2021

filipnavara commented Jul 30, 2021

mdh1418 commented Aug 3, 2021 •

edited

Loading

[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

Conversation

mdh1418 commented Jul 30, 2021 • edited Loading

filipnavara commented Jul 30, 2021

mdh1418 commented Jul 30, 2021

filipnavara commented Jul 30, 2021

mdh1418 commented Aug 3, 2021 • edited Loading

mdh1418 commented Jul 30, 2021 •

edited

Loading

mdh1418 commented Aug 3, 2021 •

edited

Loading