Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

Merged
merged 6 commits into from
Aug 6, 2021
Merged

[libraries][tvOS] Update Issue causing System.Net.Requests to fail #56624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ca5bc9
[libraries][iOS][tvOS] Update Issue causing System.Net.Requests to fail
Jul 30, 2021
5a1d580
[libraries][tvOS] Default preauthenticate in InnerSendAsync to false
Aug 3, 2021
4f83399
Defalt SendWithProxyAuthAsync doRequestAuth parameter to false
Aug 3, 2021
9c5cdc3
[libraries] Add IsBinaryFormatterSupported ConditionalFact
Aug 3, 2021
6221e2f
[libraries][tvOS] Add ActiveIssue for loopback request header reading…
Aug 3, 2021
0e660d6
Fix location of ActiveIssue
Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ystem.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.NtAuth.tvOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ internal static partial class AuthenticationHelper
private static Task<HttpResponseMessage> InnerSendAsync(HttpRequestMessage request, Uri authUri, bool async, ICredentials credentials, bool isProxyAuth, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)
{
return isProxyAuth ?
SendWithProxyAuthAsync(request, authUri, async, credentials, true, connectionPool, cancellationToken).AsTask() :
SendWithRequestAuthAsync(request, async, credentials, true, connectionPool, cancellationToken).AsTask();
SendWithProxyAuthAsync(request, authUri, async, credentials, false, connectionPool, cancellationToken).AsTask() :
SendWithRequestAuthAsync(request, async, credentials, false, connectionPool, cancellationToken).AsTask();
}

public static Task<HttpResponseMessage> SendWithNtProxyAuthAsync(HttpRequestMessage request, Uri proxyUri, bool async, ICredentials proxyCredentials, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)
Expand Down
5 changes: 3 additions & 2 deletions src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,6 +1459,7 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
[InlineData(true)]
[InlineData(false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37087", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/56798", TestPlatforms.tvOS)]
public async Task GetResponseAsync_UseDefaultCredentials_ExpectSuccess(bool useSsl)
{
var options = new LoopbackServer.Options { UseSsl = useSsl };
Expand Down Expand Up @@ -1499,6 +1500,7 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
[InlineData(true)]
[InlineData(false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37087", TestPlatforms.Android)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/56798", TestPlatforms.tvOS)]
public async Task HaveResponse_GetResponseAsync_ExpectTrue(bool useSsl)
{
var options = new LoopbackServer.Options { UseSsl = useSsl };
Expand Down Expand Up @@ -1991,8 +1993,7 @@ private static async Task VerifyResponse(string expectedResponse, Task<WebRespon
}
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37087", TestPlatforms.Android)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
public void HttpWebRequest_Serialize_Fails()
{
using (MemoryStream fs = new MemoryStream())
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Net.Requests/tests/HttpWebResponseHeaderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ await LoopbackServer.CreateServerAsync(async (server, url) =>
});
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37087", TestPlatforms.Android)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
public async Task HttpWebResponse_Serialize_ExpectedResult()
{
await LoopbackServer.CreateServerAsync(async (server, url) =>
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj" />

<!-- Crashes or hangs, did not produce testResults.xml -->
<!-- https://github.com/dotnet/runtime/issues/52117 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Requests/tests/System.Net.Requests.Tests.csproj" />
<!-- https://github.com/dotnet/runtime/issues/52120 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj" />

Expand Down