-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonzero Exit Code for performance-setup Failures #59483
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@Tohron Since we have so much repeated code in these scripts from the error checking, I think that it would be useful to write a function that takes in the command we want to check, and then does the error level checking. This would greatly simplify the code, and make adding new checks much easier. |
Created to address dotnet/performance#2010
This PR aims to cause performance-setup.ps1 and performance-setup.sh to return a nonzero exit code whenever a command in the script fails.