Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Errors in performance-setup Scripts From PR 59483 #60073

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

Tohron
Copy link
Contributor

@Tohron Tohron commented Oct 6, 2021

#59483 was merged to resolve issues with performance setup scripts not returning a nonzero exit code when they encountered failures, but some errors were found after it was merged. This PR is to address those errors.

@ghost
Copy link

ghost commented Oct 6, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

#59483 was merged to resolve issues with performance setup scripts not returning a nonzero exit code when they encountered failures, but some errors were found after it was merged. This PR is to address those errors.

Author: Tohron
Assignees: -
Labels:

area-Infrastructure-libraries, tenet-performance

Milestone: -

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tohron Tohron merged commit a442df0 into main Oct 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants