-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline caching proof of concept #62550
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache nuget packags in libraries build TOREVERT: Just build windows/x64 libraries Use Cache_Key variable No cache key PreBuildSteps fix echo statement Set cacheHitVar Add variables space space 2 no need of another variables Print CACHE_RESTORED Cache based on commit hash fix space Remove condition from upload Remove one more condition minor change Try upload artifact step misc changes in libraries Use caching for Coreclr builds Print commit hashes print dir Point to staging folder Skip zipping if using cached Add debugging logic add | Comment coreclr product for now useCached1,2,3 Change git log command upload-cached-artifact and checking about CACHE_RESTORED get-commit-hash.cmd Another CACHE_RESTORED try fix minor issue script fix use no-pager Use git log in yml Use CACHE_RESTORED in template files directly Echo git commands Temp disable building command Add -- Use python script to get commits fix the cache key add condition at one place Disable commit cachekey Move the conditions properly: Build coreclr with cache Use DAC_CACHE_RESTORED Run for all OS/platforms include arch in cache Includearch on libraries Remove failing test keys Just do windows x64/x86 Cache build log for libraries UsePipelineCache Remove the condition for DAC_CACHE_RESTORED caching fix the coreclr sample key Make space change Fix the missing ) Fix the missing ) variable UsePipelineCache Use variables.UsePipelineCache Fix the missing ) Fix variables.UsePipelineCache Add - before name/value Use cache variable names Just build libraries x64 Print build reason echo %BUILD_REASON% Change to condition Enable windows x86 libraries: fix publish logs enable libraries for all platforms use actual cache key Enable for coreclr all platforms Misc. changes + cleanup Enable Linux for debugging Use *.* Use full path Full expand Expand cache key path Cache libraries/coreclr for all platforms shorten the coreclr cache key for testing just run for win/x86 fix the cross dac problem fix the parameters removing ) Skip restore internal tools Cache build logs Reintroduce python script for git hash fix build error add logging to see why things are failing wrap in quotes python inline fix alignment: Add back print fix the yml files Run git fetch Better history fetching Enable linux x64 to check the errors convert from deepen to depth use access token replace dceng as well: fix typo Remove print tool retry logic Add git log fix exit_on_fail print git version no pager for initial log fix error Enable Linux build enable for all platforms Do not use retry logic create crossDacBuild Change from md to mkdir enable all platforms Use mkdir -p Use label proper label do not cache/restore for DAC Reenable for all platforms Use updated commit_hash file Enable libraries as well Rename some variables and comments Dummy change Revert "Dummy change" This reverts commit 645b20b7fe53e1f3787e42bee7add9895acdbc1e. Flip the condition to fix Mono builds Print source_directory Use os/subob/archtype/ Dummy change Fix the os arch names
This reverts commit 33033b8.
kunalspathak
added
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
NO-REVIEW
Experimental/testing PR, do NOT review it
labels
Dec 8, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
locked as resolved and limited conversation to collaborators
Jan 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dummy changes based on work in #62464 to validate if pipeline caching helps.