Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Use .short directive instead of .hword #64561

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

grendello
Copy link
Contributor

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the llvm-mc assembler doesn't accept .hword as a
valid directive for x86 targets. Since it's an alias for .short,
which works fine, the change should be safe across all the architectures
supported by AOT.

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the `llvm-mc` assembler doesn't accept `.hword` as a
valid directive for x86 targets.  Since it's an alias for `.short`,
which works fine, the change should be safe across all the architectures
supported by AOT.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 31, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger
Copy link
Member

/backport to release/6.0

@akoeplinger
Copy link
Member

/azp run sync-runtime-to-mono

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1779808098

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger akoeplinger merged commit 790784c into dotnet:main Feb 1, 2022
@grendello grendello deleted the aot-no-hword branch February 1, 2022 18:17
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants