Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [AOT] Use .short directive instead of .hword #64637

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2022

Backport of #64561 to release/6.0

/cc @akoeplinger @grendello

Customer Impact

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the llvm-mc assembler doesn't accept .hword as a
valid directive for x86 targets.

Testing

Manual and CI testing.

Risk

Low. Since .hword is an alias for .short, which works fine, the change should be safe across all the architectures
supported by AOT.

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the `llvm-mc` assembler doesn't accept `.hword` as a
valid directive for x86 targets.  Since it's an alias for `.short`,
which works fine, the change should be safe across all the architectures
supported by AOT.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger akoeplinger added Servicing-consider Issue for next servicing release review area-Codegen-AOT-mono os-android labels Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #64561 to release/6.0

/cc @akoeplinger @grendello

Customer Impact

Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the llvm-mc assembler doesn't accept .hword as a
valid directive for x86 targets.

Testing

Manual and CI testing.

Risk

Low. Since .hword is an alias for .short, which works fine, the change should be safe across all the architectures
supported by AOT.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, os-android, area-Codegen-AOT-mono

Milestone: -

@marek-safar marek-safar added this to the 6.0.x milestone Feb 1, 2022
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 1, 2022
@leecow leecow modified the milestones: 6.0.x, 6.0.3 Feb 1, 2022
@safern
Copy link
Member

safern commented Feb 7, 2022

@akoeplinger can we get a signoff here so that I can merge?

@akoeplinger
Copy link
Member

@safern done!

@safern safern merged commit 39f85a4 into release/6.0 Feb 7, 2022
@safern safern deleted the backport/pr-64561-to-release/6.0 branch February 7, 2022 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants