Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0][wasm][debugger] Fix incompatibility between runtime and nuget package #66301

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Mar 7, 2022

Customer Impact

When the customer created a project using release 6.0.0 and then install new versions of VS like: 6.0.2, the nuget package of the wasm project is not updated automatically, so the user uses the runtime 6.0.2 and the nuget package 6.0.0, the BrowserDebugProxy is inside this nuget package and one of our changes to show multidimensional array, caused this incompatibility.

Related Issues

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1470864
https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1484798

Testing

Manual testing

Risk

Very Low. This is just keeping the old behavior if the runtime is updated and the BrowserDebugProxy is not, so the multidimensional array will not work, but simple arrays will continue working.

@thaystg thaystg added the Servicing-consider Issue for next servicing release review label Mar 7, 2022
@thaystg thaystg requested a review from lewing March 7, 2022 17:13
@thaystg thaystg requested a review from marek-safar as a code owner March 7, 2022 17:13
@ghost ghost assigned thaystg Mar 7, 2022
@ghost
Copy link

ghost commented Mar 7, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Customer Impact

When the customer created a project using release 6.0.0 and then install new versions of VS like: 6.0.2, the nuget package of the wasm project is not updated automatically, so the user uses the runtime 6.0.2 and the nuget package 6.0.0, the BrowserDebugProxy is inside this nuget package and one of our changes to show multidimensional array, caused this incompatibility.

Testing

Manual testing

Risk

Very Low. This is just keeping the old behavior if the runtime is updated and the BrowserDebugProxy is not, so the multidimensional array will not work, but simple arrays will continue working.

Author: thaystg
Assignees: thaystg
Labels:

Servicing-consider, area-Debugger-mono

Milestone: -

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 10, 2022
@lewing
Copy link
Member

lewing commented Mar 10, 2022

approved in email

@lewing
Copy link
Member

lewing commented Mar 10, 2022

wasm AOT failure is #66366

@lambdageek lambdageek added this to the 6.0.x milestone Mar 10, 2022
@ericstj ericstj modified the milestones: 6.0.x, 6.0.4 Mar 10, 2022
@ericstj
Copy link
Member

ericstj commented Mar 10, 2022

@lewing what about the Mono Android x64 Release failures? Are those known?

@akoeplinger
Copy link
Member

@ericstj yes those are infrastructure issues (the test app failed to install on the device), tracked by #65840

@ericstj ericstj merged commit 4afa671 into dotnet:release/6.0 Mar 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants