Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0][wasm] Backport skipping System.Text.Json tests for the aot configuration #66366

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[release/6.0][wasm] Backport skipping System.Text.Json tests for the aot configuration #66366

merged 1 commit into from
Mar 10, 2022

Conversation

steveisok
Copy link
Member

Partial backport of #65413

#61524 - OOM while linking System.Text.Json.Tests

[release/6.0][wasm] Backport skipping System.Text.Json tests for aot …
81e3c86 
…configuration

Partial backport of dotnet#65413

dotnet#61524 - OOM while linking `System.Text.Json.Tests`
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned steveisok Mar 8, 2022
lewing
lewing approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really love a resolution that allows us to run these tests somewhere eventually.

@ghost
Copy link

ghost commented Mar 10, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Partial backport of #65413

#61524 - OOM while linking System.Text.Json.Tests

Author: steveisok
Assignees: steveisok
Labels:

area-System.Text.Json
Milestone: -

This was referenced Mar 10, 2022
Merged
Merged
Merged
@lewing lewing added the arch-wasm WebAssembly architecture label Mar 10, 2022
@ghost
Copy link

ghost commented Mar 10, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Partial backport of #65413

#61524 - OOM while linking System.Text.Json.Tests

Author: steveisok
Assignees: steveisok
Labels:

arch-wasm, area-System.Text.Json
Milestone: -

@lewing lewing mentioned this pull request Mar 10, 2022
Merged
@lewing
Copy link
Member

lewing commented Mar 10, 2022 •
edited
Loading

the coreclr failure appears to be #66059 caused by #65292

@lewing
Copy link
Member

lewing commented Mar 10, 2022

@carlossanlop can we get this in, it is making a lot of the other approved prs red

@carlossanlop carlossanlop merged commit 87a80d9 into dotnet:release/6.0 Mar 10, 2022
This was referenced Mar 10, 2022
Merged
Merged
This was referenced Mar 10, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@lewing lewing lewing approved these changes

Assignees

@steveisok steveisok

Labels
arch-wasm WebAssembly architecture area-System.Text.Json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steveisok @lewing @carlossanlop @danmoseley