Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add x86 host to PATH on 64-bit machines #69902

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

NikolaMilosavljevic
Copy link
Member

This fixes the remaining issue with non-native host paths in machine's environment (PATH).

The fix uses a different model than x64-on-arm64. It is a simpler change as it's easy to determine if machine is 64-bit, using WersionNT64 property. This solution avoids unnecessary changes in arcade infra and adding additional complexity.

@joeloff
Copy link
Member

joeloff commented May 28, 2022

We should document this change so that users that only install the x86 SDK on a 64-bit OS manually update the PATH variable.

@NikolaMilosavljevic
Copy link
Member Author

We should document this change so that users that only install the x86 SDK on a 64-bit OS manually update the PATH variable.

Yes, this needs to be documented as a breaking change. @richlander is there any guidance for publishing BCNs? I could help with that, unless there is an established process and team, to which I should defer this.

@richlander
Copy link
Member

https://github.com/dotnet/runtime/blob/main/docs/project/breaking-change-process.md

@NikolaMilosavljevic
Copy link
Member Author

BCN issue: #70039

@NikolaMilosavljevic NikolaMilosavljevic added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Jun 1, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jun 1, 2022
@ghost
Copy link

ghost commented Jun 1, 2022

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@NikolaMilosavljevic NikolaMilosavljevic merged commit d2e569d into dotnet:main Jun 6, 2022
@NikolaMilosavljevic NikolaMilosavljevic removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jun 6, 2022
@NikolaMilosavljevic
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2450031373

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Setup breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants