-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add x86 host to PATH on 64-bit machines #69902
Do not add x86 host to PATH on 64-bit machines #69902
Conversation
We should document this change so that users that only install the x86 SDK on a 64-bit OS manually update the PATH variable. |
Yes, this needs to be documented as a breaking change. @richlander is there any guidance for publishing BCNs? I could help with that, unless there is an established process and team, to which I should defer this. |
BCN issue: #70039 |
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2450031373 |
This fixes the remaining issue with non-native host paths in machine's environment (PATH).
The fix uses a different model than x64-on-arm64. It is a simpler change as it's easy to determine if machine is 64-bit, using WersionNT64 property. This solution avoids unnecessary changes in arcade infra and adding additional complexity.