Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Do not add x86 host to PATH on 64-bit machines #70299

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2022

Backport of #69902 to release/6.0

Fixes: #70039

Customer Impact

This fixes the remaining issue with non-native host paths in machine's environment (PATH).

The fix uses a different model than x64-on-arm64. It is a simpler change as it's easy to determine if machine is 64-bit, using WersionNT64 property. This solution avoids unnecessary changes in arcade infra and adding additional complexity.

Testing

See main issue: #70039 (comment)

Risk

As with any breaking change, this will affect some users. In this case, anyone that wants 32-bit host (dotnet.exe) to be in PATH on 64-bit machines, will need to add host location to PATH manually.

@NikolaMilosavljevic NikolaMilosavljevic added the Servicing-consider Issue for next servicing release review label Jun 9, 2022
@NikolaMilosavljevic NikolaMilosavljevic added this to the 6.0.x milestone Jun 9, 2022
@NikolaMilosavljevic
Copy link
Member

Approved offline - @joeloff @ericstj any concerns with this backport - can you approve it?

@NikolaMilosavljevic NikolaMilosavljevic added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 10, 2022
@NikolaMilosavljevic
Copy link
Member

Closing and reopening to rebase the PR - one check was failing and blocking the merge.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 3ab87d9 into release/6.0 Jun 13, 2022
@jkotas jkotas deleted the backport/pr-69902-to-release/6.0 branch June 13, 2022 22:08
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants