Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Generics support in System.Text.Json.SourceGeneration #71619

Merged
merged 5 commits into from
Jul 12, 2022
Merged

Improve Generics support in System.Text.Json.SourceGeneration #71619

merged 5 commits into from
Jul 12, 2022

Conversation

pos777
Copy link
Contributor

@pos777 pos777 commented Jul 4, 2022

fix for #62762

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 4, 2022
@dnfadmin
Copy link

dnfadmin commented Jul 4, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ghost
Copy link

ghost commented Jul 4, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

fix for #62762

Author: pos777
Assignees: -
Labels:

area-System.Text.Json, community-contribution
Milestone: -

krwq
krwq approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This greatly improves state of handling generic types and even though there are some testing gaps I believe there is a value in merging this as is. Thanks @pos777!

@krwq
Copy link
Member

krwq commented Jul 12, 2022

@pos777 consider fixing comments when you're back but don't feel pressured. I'm really glad with this addition regardless. Thank you!

@krwq krwq merged commit 0cd5fe5 into dotnet:main Jul 12, 2022
@krwq
Copy link
Member

krwq commented Jul 12, 2022

This change will be available in .NET 7 preview 7

@pos777 pos777 deleted the fix_62762 branch July 19, 2022 07:49
@pos777 pos777 mentioned this pull request Jul 19, 2022
Merged
@pos777
Copy link
Contributor Author

pos777 commented Jul 19, 2022

@krwq, I have prepared #72449 with additional tests.
Shouldn't #62762 be closed as well?

@krwq krwq mentioned this pull request Jul 20, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@krwq krwq krwq approved these changes

Assignees
No one assigned
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pos777 @dnfadmin @krwq @eiriktsarpalis