Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for Generics in System.Text.Json.SourceGeneration #72449

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

pos777
Copy link
Contributor

@pos777 pos777 commented Jul 19, 2022

Additional tests for #71619

Closes #62762

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Additional tests for #71619

Author: pos777
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@pos777 pos777 changed the title Additional tests for 71619 Additional tests for Generics in System.Text.Json.SourceGeneration Jul 20, 2022
@pos777
Copy link
Contributor Author

pos777 commented Jul 22, 2022

Is this PR good enough or should I improve it somehow?

@krwq krwq merged commit ea2c907 into dotnet:main Jul 22, 2022
@pos777 pos777 deleted the tests_for_71619 branch July 22, 2022 10:48
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json does not correctly handle nested inner types of a generic outer type.
3 participants