-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new API GetEnumValuesAsUnderlyingType #73057
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsFixes #72498,
|
Can you also change the upstack code to use this? That way we can ensure it is working correctly? Ex. runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs Lines 174 to 179 in 20b42d5
|
...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs
Show resolved
Hide resolved
...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/EnumConverter.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
...ries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoType.cs
Outdated
Show resolved
Hide resolved
…/Reflection/TypeLoading/Types/RoType.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.cs
Show resolved
Hide resolved
…Tests/Type/TypeTests.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Fixes #72498,
CoreCLR/Mono
has an override implementation andNativeAOT
has its own implementation that mirrors the original PR MakeEnum.GetValues
AOT-safe #72236.MetadataAssemblyLoadContext
that is reflection friendlyEnumTests