-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Misc tests related fixes #73884
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
… a threaded build
.. by using `MSBuild` task to build them instead of invoking `dotnet.sh`. - And fix incremental builds
- Building, and running all the tests for EAT case will help catch linker errors that can slip through.
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
I want to land this for 7.0 . |
src/libraries/System.Security.Cryptography/tests/System.Security.Cryptography.Tests.csproj
Show resolved
Hide resolved
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
This fixes trimming errors on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(primarily looked at the tasks, but the rest also makes sense to me)
haven't seen these before |
The failures are caused because:
|
There is a new linker update PR open (#73894), and this might be better solved over there.
I think we can merge this (on red). And I'll follow up in the other PR to fix all the linker issues. |
Fixes #73872
Fixes #73901