Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Misc tests related fixes #73884

Merged
merged 10 commits into from
Aug 14, 2022
Merged

[wasm] Misc tests related fixes #73884

merged 10 commits into from
Aug 14, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 13, 2022

  • Disable subtlecrypto tests
  • Improve build times for runtime packs, in case of Wasm.Build.Tests
  • Fix incremental builds for the above
  • Fix running samples on threaded builds
  • Don't run only smoke tests for EAT. This will help in catching trimming errors
  • Fix trimming errors with tests

Fixes #73872
Fixes #73901

@radical radical added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code area-Build-mono labels Aug 13, 2022
@ghost ghost assigned radical Aug 13, 2022
@ghost
Copy link

ghost commented Aug 13, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Disable subtlecrypto tests
  • Improve build times for runtime packs, in case of Wasm.Build.Tests
  • Fix incremental builds for the above
  • Fix running samples on threaded builds
Author: radical
Assignees: -
Labels:

arch-wasm, test-enhancement, area-Build-mono

Milestone: -

@radical
Copy link
Member Author

radical commented Aug 13, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical changed the title [wasm] Misc fixes [wasm] Misc tests, and build fixes Aug 13, 2022
@radical radical changed the title [wasm] Misc tests, and build fixes [wasm] Misc tests related fixes Aug 13, 2022
@radical radical marked this pull request as ready for review August 13, 2022 12:08
@radical radical requested review from steveisok, lewing, akoeplinger and eerhardt and removed request for lewing and pavelsavara August 13, 2022 12:08
- Building, and running all the tests for EAT case will help catch
linker errors that can slip through.
@radical radical requested a review from lambdageek August 13, 2022 15:18
@radical
Copy link
Member Author

radical commented Aug 13, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical removed the request for review from lambdageek August 13, 2022 15:19
@radical radical requested review from pavelsavara and maraf August 13, 2022 15:19
@radical radical added this to the 7.0.0 milestone Aug 13, 2022
@radical
Copy link
Member Author

radical commented Aug 13, 2022

I want to land this for 7.0 .

@radical
Copy link
Member Author

radical commented Aug 13, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 13, 2022

This fixes trimming errors on main too.

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(primarily looked at the tasks, but the rest also makes sense to me)

@lambdageek
Copy link
Member

Starting:    System.Runtime.Serialization.Json.ReflectionOnly.Tests.dll
[19:15:51] fail: [FAIL] DataContractJsonSerializerTests.DCJS_VerifyDateTimeForFormatStringDCJsonSerSettings
[19:15:51] info: System.InvalidOperationException : No set method for property 'UtcDateTime' in type 'System.Runtime.Serialization.DateTimeOffsetAdapter'.
[19:15:51] info:    at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
[19:15:51] info:    at DataContractJsonSerializerTests.SerializeAndDeserialize[DateTimeOffset](DateTimeOffset value, String baseline, DataContractJsonSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare)
[19:15:51] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )
[19:15:52] fail: [FAIL] DataContractJsonSerializerTests.DCJS_ClassWithDatetimeOffsetTypeProperty
[19:15:52] info: System.InvalidOperationException : No set method for property 'UtcDateTime' in type 'System.Runtime.Serialization.DateTimeOffsetAdapter'.
[19:15:52] info:    at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
[19:15:52] info:    at DataContractJsonSerializerTests.SerializeAndDeserialize[TypeWithDateTimeOffsetTypeProperty](TypeWithDateTimeOffsetTypeProperty value, String baseline, DataContractJsonSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare)
[19:15:52] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )
[19:15:52] info: Finished:    System.Runtime.Serialization.Json.ReflectionOnly.Tests.dll

haven't seen these before

@radical
Copy link
Member Author

radical commented Aug 14, 2022

The failures are caused because:

  1. main has trimming errors, which we fixed here ([wasm] Tests failing to build with trimming #73901)
  2. And we are now (as of this PR) running all the EAT tests, which then reveals the errors that you mentioned caused by trimming.

@radical
Copy link
Member Author

radical commented Aug 14, 2022

There is a new linker update PR open (#73894), and this might be better solved over there.
So, w.r.t the linker issues:

  • this PR makes the situation slightly better but doesn't fully fix it.
  • does not make it worse!

I think we can merge this (on red). And I'll follow up in the other PR to fix all the linker issues.

@radical radical merged commit 7d986fa into dotnet:main Aug 14, 2022
@radical radical deleted the misc-fixes branch August 14, 2022 01:30
@ghost ghost locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono test-enhancement Improvements of test source code
Projects
None yet
4 participants