[main] Update dependencies from dotnet/linker #73894

dotnet-maestro · 2022-08-13T12:12:59Z

This pull request updates the following dependencies

From https://github.com/dotnet/linker

Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
Build: 20220812.4
Date Produced: August 12, 2022 9:42:40 PM UTC
Commit: fda7b09fc005acb865deaf526c7adbb1be27a5f9
Branch: refs/heads/main

Updates:
- Microsoft.NET.ILLink.Tasks: from 7.0.100-1.22412.3 to 7.0.100-1.22412.4

Fixes some of #73961, and some tests disabled
Fixes #73933

…812.4 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22412.3 -> To Version 7.0.100-1.22412.4

radical · 2022-08-13T14:16:15Z

/azp run runtime-wasm,runtime-wasm-perf

azure-pipelines · 2022-08-13T14:16:33Z

Azure Pipelines successfully started running 2 pipeline(s).

radical · 2022-08-13T15:04:44Z

main has linker errors too - #73901

radical · 2022-08-13T15:25:06Z

main has linker errors too - #73901

This got introduced with the previous linker update. In #73884 I'm enabling the wasm/trimming tests to run fully on linker updates, so we don't have this in future.

…61-47d0-8363-f97c6653cf46

radical · 2022-08-14T01:31:38Z

/azp run runtime-wasm

azure-pipelines · 2022-08-14T01:31:47Z

Azure Pipelines successfully started running 1 pipeline(s).

.. errors. ``` [22:32:27] fail: [FAIL] DataContractJsonSerializerTests.DCJS_VerifyDateTimeForFormatStringDCJsonSerSettings [22:32:27] info: System.InvalidOperationException : No set method for property 'UtcDateTime' in type 'System.Runtime.Serialization.DateTimeOffsetAdapter'. [22:32:27] info: at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver) [22:32:27] info: at DataContractJsonSerializerTests.SerializeAndDeserialize[DateTimeOffset](DateTimeOffset value, String baseline, DataContractJsonSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare) [22:32:27] info: at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags ) [22:32:27] fail: [FAIL] DataContractJsonSerializerTests.DCJS_ClassWithDatetimeOffsetTypeProperty [22:32:27] info: System.InvalidOperationException : No set method for property 'UtcDateTime' in type 'System.Runtime.Serialization.DateTimeOffsetAdapter'. [22:32:27] info: at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver) [22:32:27] info: at DataContractJsonSerializerTests.SerializeAndDeserialize[TypeWithDateTimeOffsetTypeProperty](TypeWithDateTimeOffsetTypeProperty value, String baseline, DataContractJsonSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare) [22:32:27] info: at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags ) ```

``` fail: [FAIL] System.Runtime.Serialization.Schema.Tests.ImporterTests.Import(import: Action`1 { Method = Void <Import_MemberData>b__7(System.Runtime.S erialization.XsdDataContractImporter), Target = <>c__DisplayClass7_1 { schemaSet = XmlSchemaSet { ... }, typeName = http://schemas.datacontract.org/200 4/07/System.Runtime.Serialization.Schema.Tests:ImporterTests.SerializableFormatClass } }, codeLength: -1) info: System.MissingMethodException : No parameterless constructor defined for type 'Microsoft.CSharp.CSharpCodeProvider'. info: at System.RuntimeType.CreateInstanceMono(Boolean , Boolean ) info: at System.RuntimeType.CreateInstanceDefaultCtor(Boolean , Boolean ) info: at System.Activator.CreateInstance(Type type, Boolean nonPublic, Boolean wrapExceptions) info: at System.Activator.CreateInstance(Type type, Boolean nonPublic) info: at System.Activator.CreateInstance(Type type) info: at System.CodeDom.Compiler.CompilerInfo.CreateProvider() info: at System.CodeDom.Compiler.CodeDomProvider.CreateProvider(String ) info: at System.Runtime.Serialization.Schema.Tests.SchemaUtils.DumpCode(CodeCompileUnit ccu, CodeDomProvider provider) info: at System.Runtime.Serialization.Schema.Tests.ImporterTests.Import(Action`1 import, Int32 codeLength) info: at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags ) ```

.. linker errors. ``` [02:47:16] fail: [FAIL] DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter [02:47:16] info: System.Runtime.Serialization.InvalidDataContractException : No get method for property 'Capacity' in type 'System.Runtime.Serialization.MemoryStreamAdapter'. [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.ThrowInvalidDataContractException(String , Type ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.ThrowInvalidDataContractException(String ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.ClassDataContract.ClassDataContractCriticalHelper.ImportDataMembers() [02:47:16] info: at System.Runtime.Serialization.DataContracts.ClassDataContract.ClassDataContractCriticalHelper..ctor(Type ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.ClassDataContract..ctor(Type ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.CreateDataContract(Type ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.CreateDataContract(Int32 , RuntimeTypeHandle , Type ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.GetDataContractSkipValidation(Int32 , RuntimeTypeHandle , Type ) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.GetDataContractSkipValidation(Int32 id, RuntimeTypeHandle typeHandle, Type type) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.GetDataContract(RuntimeTypeHandle typeHandle, Type type) [02:47:16] info: at System.Runtime.Serialization.DataContracts.DataContract.GetDataContract(Type type) [02:47:16] info: at System.Runtime.Serialization.DataContractSerializer.get_RootContract() [02:47:16] info: at System.Runtime.Serialization.DataContractSerializer.InternalWriteStartObject(XmlWriterDelegator writer, Object graph) [02:47:16] info: at System.Runtime.Serialization.DataContractSerializer.InternalWriteObject(XmlWriterDelegator writer, Object graph, DataContractResolver dataContractResolver) [02:47:16] info: at System.Runtime.Serialization.XmlObjectSerializer.WriteObjectHandleExceptions(XmlWriterDelegator writer, Object graph, DataContractResolver dataContractResolver) [02:47:16] info: at System.Runtime.Serialization.XmlObjectSerializer.WriteObjectHandleExceptions(XmlWriterDelegator writer, Object graph) [02:47:16] info: at System.Runtime.Serialization.XmlObjectSerializer.WriteObject(XmlDictionaryWriter , Object ) [02:47:16] info: at System.Runtime.Serialization.XmlObjectSerializer.WriteObject(Stream , Object ) [02:47:16] info: at System.Runtime.Serialization.Tests.DataContractSerializerHelper.SerializeAndDeserialize[MemoryStream](MemoryStream value, String baseline, DataContractSerializerSettings settings, Func`1 serializerFactory, Boolean skipStringCompare) [02:47:16] info: at DataContractSerializerTests.<DCS_MemoryStream_Serialize_UsesBuiltInAdapter>g__ValidateObject|240_0(MemoryStream original, String expectedXml, Byte[] expectedData, Int32 expectedPosition, Boolean expectedExposable) [02:47:16] info: at DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter() [02:47:16] info: at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags ) ```

``` [02:47:21] fail: [FAIL] XmlSerializerTests.Xml_ImmutableCollections(type: typeof(System.Collections.Immutable.ImmutableArray<int>), collection: [42], createException: null, addException: typeof(System.InvalidOperationException), expectedXml: "<?xml version=\"1.0\" encoding=\"utf-8\"?><ArrayOf"..., exMsg: "Specified method is not supported.") [02:47:21] info: System.InvalidOperationException : There was an error generating the XML document. [02:47:21] info: ---- System.InvalidOperationException : To be XML serializable, types which inherit from ICollection must have an implementation of Add(System.Int32) at all levels of their inheritance hierarchy. System.Collections.Immutable.ImmutableArray`1[[System.Int32, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]] does not implement Add(System.Int32). [02:47:21] info: at System.Xml.Serialization.XmlSerializer.Serialize(XmlWriter xmlWriter, Object o, XmlSerializerNamespaces namespaces, String encodingStyle, String id) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.Serialize(XmlWriter xmlWriter, Object o, XmlSerializerNamespaces namespaces, String encodingStyle) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.Serialize(XmlWriter xmlWriter, Object o, XmlSerializerNamespaces namespaces) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.Serialize(Stream stream, Object o, XmlSerializerNamespaces namespaces) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.Serialize(Stream stream, Object o) [02:47:21] info: at XmlSerializerTests.Serialize[Object](Object value, String baseline, Func`1 serializerFactory, Boolean skipStringCompare, XmlSerializerNamespaces xns) [02:47:21] info: at XmlSerializerTests.Xml_ImmutableCollections(Type type, Object collection, Type createException, Type addException, String expectedXml, String exMsg) [02:47:21] info: at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags ) [02:47:21] info: ----- Inner Stack Trace ----- [02:47:21] info: at System.Xml.Serialization.TypeScope.GetDefaultIndexer(Type , String ) [02:47:21] info: at System.Xml.Serialization.TypeScope.GetCollectionElementType(Type , String ) [02:47:21] info: at System.Xml.Serialization.TypeScope.ImportTypeDesc(Type , MemberInfo , Boolean ) [02:47:21] info: at System.Xml.Serialization.TypeScope.GetTypeDesc(Type , MemberInfo , Boolean , Boolean ) [02:47:21] info: at System.Xml.Serialization.TypeScope.GetTypeDesc(Type , MemberInfo , Boolean ) [02:47:21] info: at System.Xml.Serialization.ModelScope.GetTypeModel(Type , Boolean ) [02:47:21] info: at System.Xml.Serialization.ModelScope.GetTypeModel(Type ) [02:47:21] info: at System.Xml.Serialization.XmlReflectionImporter.ImportTypeMapping(Type , XmlRootAttribute , String ) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.GenerateXmlTypeMapping(Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, String defaultNamespace) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.GetMapping() [02:47:21] info: at System.Xml.Serialization.XmlSerializer.SerializeUsingReflection(XmlWriter xmlWriter, Object o, XmlSerializerNamespaces namespaces, String encodingStyle, String id) [02:47:21] info: at System.Xml.Serialization.XmlSerializer.Serialize(XmlWriter xmlWriter, Object o, XmlSerializerNamespaces namespaces, String encodingStyle, String id) ```

…7c6653cf46

radical · 2022-08-15T07:58:26Z

/azp run runtime-wasm

azure-pipelines · 2022-08-15T07:58:38Z

Azure Pipelines successfully started running 1 pipeline(s).

`IL2121` was disabled for samples, but the project discard the value of `$(NoWarn)`, thus missing the warning code. ``` ILLink : Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource: Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2113'. Consi der removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] ILLink : Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource: Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2115'. Consi der removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(885,9): Trim analysis error IL2121: System.Diagn ostics.Tracing.EventSource.WriteEvent(Int32, Int64, Int64, Int64): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removi ng the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1067,9): Trim analysis error IL2121: System.Diag nostics.Tracing.EventSource.WriteEvent(Int32, Int32, String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing th e unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(955,9): Trim analysis error IL2121: System.Diagn ostics.Tracing.EventSource.WriteEvent(Int32, String, String, String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider rem oving the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(927,9): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEvent(Int32, String, String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(796,9): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEvent(Int32, Int32): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1366,13): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEvent(Int32, Object[]): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2112'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(904,9): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEvent(Int32, String): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2026'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1236,13): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEventCore(Int32, Int32, EventData*): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2112'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1959,9): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEventVarargs(Int32, Guid*, Object[]): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2112'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sample.csproj] /workspaces/runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs(1350,9): Trim analysis error IL2121: System.Diagnostics.Tracing.EventSource.WriteEventWithRelatedActivityIdCore(Int32, Guid*, Int32, EventData*): Unused 'UnconditionalSuppressMessageAttribute' for warning 'IL2112'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sa mple.csproj] ILLink : Trim analysis error IL2121: System.Resources.ResourceReader.DeserializeObject(Int32): Unused 'UnconditionalSuppressMessageAttribute' for warni ng 'IL2026'. Consider removing the unused warning suppression. [/workspaces/runtime/src/mono/sample/wasm/browser-eventpipe/Wasm.Browser.EventPipe.Sampl e.csproj] ``` Fixes #73933 .

…61-47d0-8363-f97c6653cf46

radical · 2022-08-15T09:45:35Z

/azp run runtime-wasm

azure-pipelines · 2022-08-15T09:45:44Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-08-15T17:31:45Z

What should be done in this case? @eerhardt @vitek-karas
log:

[11:27:00] fail: [FAIL] System.Runtime.Serialization.Schema.Tests.RoundTripTest.RountTripTest
[11:27:00] info: System.Runtime.Serialization.InvalidDataContractException : Type 'System.ComponentModel.MarshalByValueComponent' cannot be serialized. Consider marking it with the DataContractAttribute attribute, and marking all of its members you want serialized with the DataMemberAttribute attribute. Alternatively, you can ensure that the type is public and has a parameterless constructor - all public members of the type will then be serialized, and no attributes will be required.
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.ThrowInvalidDataContractException(String , Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.CreateDataContract(Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.CreateDataContract(Int32 , RuntimeTypeHandle , Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.GetDataContractSkipValidation(Int32 , RuntimeTypeHandle , Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.GetDataContractSkipValidation(Int32 id, RuntimeTypeHandle typeHandle, Type type)
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.GetDataContract(RuntimeTypeHandle typeHandle, Type type)
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.GetDataContract(Type type)
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.ClassDataContract.ClassDataContractCriticalHelper..ctor(Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.ClassDataContract..ctor(Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.CreateDataContract(Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.CreateDataContract(Int32 , RuntimeTypeHandle , Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.DataContractCriticalHelper.GetDataContractSkipValidation(Int32 , RuntimeTypeHandle , Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.GetDataContractSkipValidation(Int32 id, RuntimeTypeHandle typeHandle, Type type)
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.GetDataContract(RuntimeTypeHandle typeHandle, Type type)
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContract.GetDataContract(Type type)
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.GetDataContract(Type )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.GetMemberTypeDataContract(DataMember )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.AddClassDataContract(ClassDataContract )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.InternalAdd(XmlQualifiedName , DataContract )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.Add(XmlQualifiedName , DataContract )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.Add(DataContract )
[11:27:00] info:    at System.Runtime.Serialization.DataContracts.DataContractSet.Add(Type )
[11:27:00] info:    at System.Runtime.Serialization.XsdDataContractExporter.AddType(Type )
[11:27:00] info:    at System.Runtime.Serialization.XsdDataContractExporter.Export(Type )
[11:27:00] info:    at System.Runtime.Serialization.Schema.Tests.RoundTripTest.RountTripTest()
[11:27:00] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )

radical · 2022-08-15T17:38:55Z

Type 'System.ComponentModel.MarshalByValueComponent' cannot be serialized. Consider marking it with the DataContractAttribute attribute, and marking all of its members you want serialized with the DataMemberAttribute attribute. Alternatively, you can ensure that the type is public and has a parameterless constructor - all public members of the type will then be serialized, and no attributes will be required.

should that be done?

lewing · 2022-08-15T17:47:12Z

MarshalByValueComponent

Is the public parameterless constructor being linked out now?

…61-47d0-8363-f97c6653cf46

radical · 2022-08-15T18:50:27Z

Builds breaking with:
src/libraries/Common/src/Interop/Unix/Interop.IOErrors.cs(53,70): error CS1739: The best overload for 'ThrowExceptionForIoErrno' does not have a parameter named 'isDirectory' [/__w/1/s/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj

…61-47d0-8363-f97c6653cf46

radical · 2022-08-15T19:50:15Z

/azp run runtime-wasm

azure-pipelines · 2022-08-15T19:50:29Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-08-15T21:45:04Z

runtime-staging - Build Browser wasm windows Release LibraryTests - is failure to upload results from helix. This job is also included in runtime-wasm.

lewing · 2022-08-15T22:08:32Z

the mono minijit Pri0 Runtime Tests Run OSX x64 release failed failure is also a failure to upload

radical · 2022-08-15T23:05:22Z

wasm/library tests - linux/windows, and AOT library tests are helix upload failures.

radical · 2022-08-15T23:19:35Z

The wasm tests are passing, AFAICS. The remaining ones aren't the tests that were failing with linker in previous builds.
This PR has build, and test fixes for issues present on main.
In my opinion, we should merge this PR now, and that will help unblock main, so failures on wasm don't slip through in other PRs.

carlossanlop · 2022-08-16T19:23:47Z

@radical @lewing just so you know: This PR will be included in RC1 since we had to delay the snap for a full day. Letting you know in case that was not your intention and would like to do something about it.

Update dependencies from https://github.com/dotnet/linker build 20220…

c631905

…812.4 Microsoft.NET.ILLink.Tasks From Version 7.0.100-1.22412.3 -> To Version 7.0.100-1.22412.4

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Aug 13, 2022

radical mentioned this pull request Aug 14, 2022

[wasm] Misc tests related fixes #73884

Merged

Merge remote-tracking branch 'origin/main' into darc-main-5b7e8a2c-82…

172fa0e

…61-47d0-8363-f97c6653cf46

radical added 5 commits August 15, 2022 05:01

Merge branch 'linker-fixes' into darc-main-5b7e8a2c-8261-47d0-8363-f9…

038b2c5

…7c6653cf46

radical mentioned this pull request Aug 15, 2022

[wasm] Test failures due to trimming errors on main #73932

Closed

radical added 2 commits August 15, 2022 09:21

Merge remote-tracking branch 'origin/main' into darc-main-5b7e8a2c-82…

e9c6bf8

…61-47d0-8363-f97c6653cf46

dotnet-maestro bot requested review from lewing and pavelsavara as code owners August 15, 2022 09:41

radical mentioned this pull request Aug 15, 2022

[trimming] Test failures only when trimming #73961

Open

radical added 2 commits August 15, 2022 17:56

[wasm] Disable tests failing with trimming

8029bc2

Merge remote-tracking branch 'origin/main' into darc-main-5b7e8a2c-82…

1bf0269

…61-47d0-8363-f97c6653cf46

Merge remote-tracking branch 'origin/main' into darc-main-5b7e8a2c-82…

fc11975

…61-47d0-8363-f97c6653cf46

lewing approved these changes Aug 15, 2022

View reviewed changes

radical approved these changes Aug 15, 2022

View reviewed changes

radical merged commit 86f1fb5 into main Aug 15, 2022

radical deleted the darc-main-5b7e8a2c-8261-47d0-8363-f97c6653cf46 branch August 15, 2022 23:26

ghost locked as resolved and limited conversation to collaborators Sep 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/linker #73894

[main] Update dependencies from dotnet/linker #73894

dotnet-maestro bot commented Aug 13, 2022 •

edited by radical

Loading

radical commented Aug 13, 2022

azure-pipelines bot commented Aug 13, 2022

radical commented Aug 13, 2022

radical commented Aug 13, 2022

radical commented Aug 14, 2022

azure-pipelines bot commented Aug 14, 2022

radical commented Aug 15, 2022

azure-pipelines bot commented Aug 15, 2022

radical commented Aug 15, 2022

azure-pipelines bot commented Aug 15, 2022

radical commented Aug 15, 2022

radical commented Aug 15, 2022

lewing commented Aug 15, 2022

radical commented Aug 15, 2022

radical commented Aug 15, 2022

azure-pipelines bot commented Aug 15, 2022

radical commented Aug 15, 2022

lewing commented Aug 15, 2022 •

edited

Loading

radical commented Aug 15, 2022

radical commented Aug 15, 2022

carlossanlop commented Aug 16, 2022

[main] Update dependencies from dotnet/linker #73894

[main] Update dependencies from dotnet/linker #73894

Conversation

dotnet-maestro bot commented Aug 13, 2022 • edited by radical Loading

From https://github.com/dotnet/linker

radical commented Aug 13, 2022

azure-pipelines bot commented Aug 13, 2022

radical commented Aug 13, 2022

radical commented Aug 13, 2022

radical commented Aug 14, 2022

azure-pipelines bot commented Aug 14, 2022

radical commented Aug 15, 2022

azure-pipelines bot commented Aug 15, 2022

radical commented Aug 15, 2022

azure-pipelines bot commented Aug 15, 2022

radical commented Aug 15, 2022

radical commented Aug 15, 2022

lewing commented Aug 15, 2022

radical commented Aug 15, 2022

radical commented Aug 15, 2022

azure-pipelines bot commented Aug 15, 2022

radical commented Aug 15, 2022

lewing commented Aug 15, 2022 • edited Loading

radical commented Aug 15, 2022

radical commented Aug 15, 2022

carlossanlop commented Aug 16, 2022

dotnet-maestro bot commented Aug 13, 2022 •

edited by radical

Loading

lewing commented Aug 15, 2022 •

edited

Loading