Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of SString::Printf() accepting WCHAR #76571

Merged
merged 9 commits into from
Oct 5, 2022
Merged

Remove all uses of SString::Printf() accepting WCHAR #76571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
705088b
Remove uses of SString::Printf(const WCHAR*, ...)
AaronRobinsonMSFT Oct 3, 2022
cd1b9a9
Rename SString::Printf to SString::_Printf
AaronRobinsonMSFT Oct 3, 2022
dc75c07
Remove usages of SString::Printf(const WCHAR*, ...)
AaronRobinsonMSFT Oct 3, 2022
fc325b0
Remove SString::_Printf(const WCHAR *format, ...)
AaronRobinsonMSFT Oct 3, 2022
0a13284
Use char instead of char* overload
AaronRobinsonMSFT Oct 3, 2022
acd9166
Fix logic for flag check
AaronRobinsonMSFT Oct 4, 2022
248f96a
Remove unnecessary SString usage
AaronRobinsonMSFT Oct 4, 2022
da778e3
Remove unused dbg event redirection logic
AaronRobinsonMSFT Oct 4, 2022
e2152e3
Allot size for null
AaronRobinsonMSFT Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreclr/binder/bindertracing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@ namespace BinderTracing

case FUSION_E_REF_DEF_MISMATCH:
result = Result::MismatchedAssemblyName;
errorMsg.Printf(W("Requested assembly name '%s' does not match found assembly name"), m_assemblyName.GetUnicode());
errorMsg.Append(W("Requested assembly name '"));
errorMsg.Append(m_assemblyName.GetUnicode());
errorMsg.Append(W("' does not match found assembly name"));
if (resultAssembly != nullptr)
{
errorMsg.Append(W(" '"));
Expand All @@ -325,7 +327,7 @@ namespace BinderTracing
else
{
result = Result::Failure;
errorMsg.Printf(W("Resolution failed with HRESULT (%08x)"), m_hr);
errorMsg.Printf("Resolution failed with HRESULT (%08x)", m_hr);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/binder/textualidentityparser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ namespace BINDER_SPACE
if (AssemblyIdentity::Have(dwIdentityFlags, AssemblyIdentity::IDENTITY_FLAG_VERSION))
{
tmpString.Clear();
tmpString.Printf(W("%d.%d.%d.%d"),
tmpString.Printf("%d.%d.%d.%d",
(DWORD)(USHORT)pAssemblyIdentity->m_version.GetMajor(),
(DWORD)(USHORT)pAssemblyIdentity->m_version.GetMinor(),
(DWORD)(USHORT)pAssemblyIdentity->m_version.GetBuild(),
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/debug/di/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ set(CORDBDI_SOURCES
dbgtransportmanager.cpp
hash.cpp
module.cpp
nativepipeline.cpp
platformspecific.cpp
process.cpp
rsappdomain.cpp
Expand Down
349 changes: 0 additions & 349 deletions src/coreclr/debug/di/eventredirectionpipeline.cpp
View file
Open in desktop

This file was deleted.

Loading