-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md's to use "contribution bar" #77134
Conversation
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsAn update to #76567 based on various discussions. Instead of using "Active", "Inactive" and "Legacy" for the "Status", change wording to "contribution bar" that more accurately describes what type of PRs and issues are expected for each library. The contribution bar essentially is the acceptable risk and investment level for each library given the current status of the library and is composed of a single primary bar and optional secondary bars. cc @joperezr per our offline review
|
- **We take test changes** | ||
- **We don't take style-only changes** | ||
|
||
### Primary bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a library has a different composition, the thinking is it doesn't necessarily need to update this list and doesn't necessarily need to link back to here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you for pioneering this for us.
My only suggestion is to change "we take" to "we consider" and "we don't take" to "we don't accept."
An update to #76567 based on various discussions.
Instead of using "Active", "Inactive" and "Legacy" for the "Status", change wording to "contribution bar" that more accurately describes what type of PRs and issues are expected for each library. The contribution bar essentially is the acceptable risk and investment level for each library given the current status of the library and is composed of a single primary bar and optional secondary bars.
cc @joperezr per our offline review