Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md's to use "contribution bar" #77134

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

steveharter
Copy link
Member

An update to #76567 based on various discussions.

Instead of using "Active", "Inactive" and "Legacy" for the "Status", change wording to "contribution bar" that more accurately describes what type of PRs and issues are expected for each library. The contribution bar essentially is the acceptable risk and investment level for each library given the current status of the library and is composed of a single primary bar and optional secondary bars.

cc @joperezr per our offline review

@steveharter steveharter added documentation Documentation bug or enhancement, does not impact product or test code area-System.Reflection labels Oct 17, 2022
@steveharter steveharter self-assigned this Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

An update to #76567 based on various discussions.

Instead of using "Active", "Inactive" and "Legacy" for the "Status", change wording to "contribution bar" that more accurately describes what type of PRs and issues are expected for each library. The contribution bar essentially is the acceptable risk and investment level for each library given the current status of the library and is composed of a single primary bar and optional secondary bars.

cc @joperezr per our offline review

Author: steveharter
Assignees: steveharter
Labels:

documentation, area-System.Reflection

Milestone: -

- **We take test changes**
- **We don't take style-only changes**

### Primary bar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a library has a different composition, the thinking is it doesn't necessarily need to update this list and doesn't necessarily need to link back to here.

src/libraries/README.md Outdated Show resolved Hide resolved
src/libraries/README.md Outdated Show resolved Hide resolved
Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for pioneering this for us.

My only suggestion is to change "we take" to "we consider" and "we don't take" to "we don't accept."

src/libraries/README.md Outdated Show resolved Hide resolved
@steveharter steveharter merged commit 0796729 into dotnet:main Oct 18, 2022
@steveharter steveharter deleted the ReadMes branch October 18, 2022 17:18
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection documentation Documentation bug or enhancement, does not impact product or test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants