-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readmes for System.Runtime, System.Runtime.Numerics, System.Buffers, System.Runtime.Intrinsics #77332
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsBuilding off of the standard set here: #77134. This is very much a first draft/WIP, and input is definitely appreciated. I marked areas I need input on with TODOs. Additionally, here are some other things we might want to borrow from the reflection READMEs:
Additionally, it is unclear to me whether or not I am correctly correlating namespaces, libraries, area labels, and source code locations. For example, the difference between
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about the NuGet packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested breaking the tests out into their own headings where appropriate, and avoiding the "tests ... live in ..." wording with differently structured bullets instead.
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
@jkotas Thanks for the review, and good catch. I think this is all from a single typo that propagated via copy paste. All instances of "coreclr" should definitely be "libraries". I'll update this now. |
The source of my error was copy-pasting the reference to System.Private.CoreLib from this PR, which references coreclr instead of libraries: https://github.com/dotnet/runtime/pull/76567/files. |
Building off of the standard set here: #77134.
This is very much a first draft/WIP, and input is definitely appreciated. I marked areas I need input on with TODOs.
Additionally, here are some other things we might want to borrow from the reflection READMEs:
Additionally, it is unclear to me whether or not I am correctly correlating namespaces, libraries, area labels, and source code locations. For example, the difference between
System.Numerics
andSystem.Runtime.Numerics
, and the difference betweenSystem.Runtime
andSystem
. If this stuff is confusing to me, it is probably confusing to other contributors, so we should make sure we clearly explain these connections. Let me know if I've made any mistakes there.