-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HashTo/GetCurrentHashAs{UInt32/64} methods #78075
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
@bartonjs, mind taking a look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Based on the conversation I had with @GrabYourPitchforks when the API was proposed, and our assertion of GetCurrentHashCode()
being king, I'd expect the endianness comments in all of the integer-based values (as a remarks remark or just as part of the returns ("Returns the [whatever algorithm] hash code using little-endian byte ordering."), maybe with a <seealso cref="GetCurrentHash()" />
.
Thanks for the review. |
Hi @stephentoub , the new test cases added here all fail on s390x, from the logs it looks like an obvious endian problem:
etc. |
Fixes #76279