Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NonCryptoHashTestDriver.AssertEqualHashNumber for big endian #79135

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Dec 2, 2022

@ghost
Copy link

ghost commented Dec 2, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #78075 (comment)
cc: @uweigand

Author: stephentoub
Assignees: -
Labels:

area-System.IO

Milestone: -

@stephentoub
Copy link
Member Author

/azp run runtime-community

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger akoeplinger merged commit 47e26b2 into dotnet:main Dec 2, 2022
@akoeplinger
Copy link
Member

The test failure is unrelated: #74838

@uweigand
Copy link
Contributor

uweigand commented Dec 2, 2022

Thanks for the fix, @stephentoub and @akoeplinger !

This fixed the 8 test failures I was seeing. Unfortunately CI still isn't green as 4 new failures came in in the meantime: #77944 (comment)

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2023
@stephentoub stephentoub deleted the fixbigendianhash branch June 29, 2023 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants