-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix System.Management wminet_utils.dll lookup code for arm64 #83522
Conversation
Tagging subscribers to this area: @dotnet/area-system-management Issue DetailsContinuation of #83439 @Dharmateja-Challa-Dell are you OK with me working on the fix based on your proposed changes? I cherry-picked your commit into my branch.
|
src/libraries/System.Management/tests/System/Management/ManagementClassTests.cs
Outdated
Show resolved
Hide resolved
5be2cd8
to
3c2e329
Compare
b5c8ed2
to
2a6b0f4
Compare
I locally ran the System.Management tests in my arm64 laptop. They passed:
The full output xml shows the list of tests that ran:
|
Even though windows arm64 libraries don't run per PR and I can't find a way to trigger them, @carlossanlop was so kind to test it locally on his machine and the relevant tests passed. I think we can merge the PR in. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/4441343949 |
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4441444531 |
Fixes #81400
It's highly unlikely that there will be another side by side .NET Framework installation and as we were already using
CompatSwitches.DotNetVersion
as the folder probe path, we follow that approach for arm64 as well.