-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trimming] Test failures only when trimming #73961
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSeen on [System.Runtime.Serialization.Schema.Tests log][https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-73894-merge-81b30ad20ea9433393/normal-System.Runtime.Serialization.Schema.Tests/1/console.2e21e33a.log?helixlogtype=result]:
System.Runtime.Serialization.Xml.ReflectionOnly.Tests log:
System.Runtime.Serialization.Xml.Tests log:
|
Likely the result of dotnet/linker#2929, which turned off the serialization heuristics by default. |
@sbomer, @lewing, and @radical - What is the expected path forward here? The serializer assemblies are not field-level trimmable. This isn't really an 'area-Serialization' issue as nothing changed with the serializers to cause this. Who should be responsible for ensuring that the serialization exceptions are enabled when running serialization tests? |
System.Runtime.Serialization.Xml.ReflectionOnly.Tests:DataContractSerializerTests.DCS_MemoryStream_Deserialize_CompatibleWithFullFramework Issue: dotnet#73961
* [wasi] Disable failing tests in System.Runtime.Serialization.Xml.Tests Issue: #82967, and #73961 * [wasi] Disable failing test System.Runtime.Serialization.Xml.ReflectionOnly.Tests:DataContractSerializerTests.DCS_MemoryStream_Deserialize_CompatibleWithFullFramework Issue: #73961 * [wasi] Disable tests failing depending on tmp fs System.Runtime.Serialization.Xml.ReflectionOnly.Tests, and System.Runtime.Serialization.Xml.Tests Test: DataContractSerializerTests.DCS_FileStreamSurrogate Issue: #85690
All failures
Seen on
main
, and #73894 :Rolling builds failing due to trimming errors like:
normal-System.Runtime.Serialization.Json.ReflectionOnly.Testsnormal-System.Runtime.Serialization.Json.Testsnormal-System.Runtime.Serialization.Xml.ReflectionOnly.Testsnormal-System.Runtime.Serialization.Xml.TestsThe trimming related build errors were fixed in 7d986fa . These are actual test failures now. I have pushed fixes for some of these to #73894 .
cc @eerhardt @stephentoub
Failures for which the tests have been disabled
System.Runtime.Serialization.Schema.Tests log:
System.Runtime.Serialization.Xml.ReflectionOnly.Tests log:
System.Runtime.Serialization.Xml.Tests log:
Report
Summary
The text was updated successfully, but these errors were encountered: