Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump main pre-release version iteration to preview4 #83691

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

carlossanlop
Copy link
Member

@carlossanlop carlossanlop commented Mar 20, 2023

Must only merge after the snap is done. Edit: The snap has been done: release/8.0-preview3

cc @radical @lewing @steveisok in case we see any unexpected wasm/mono issues due to version bumping.

@ghost
Copy link

ghost commented Mar 20, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Must only merge after the snap is done.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure-libraries

Milestone: -

@steveisok
Copy link
Member

the WBT failure is:

Wasm.Build.NativeRebuild.Tests.FlagsChangeRebuildTests.ExtraEmccFlagsSetButNoRealChange(buildArgs: BuildArgs { ProjectName = placeholder, Config = Release, AOT = False, ProjectFileContents = placeholder, ExtraBuildArgs =  }, extraCFlags: "/p:EmccExtraCFlags=-g", extraLDFlags: "", host: Chrome, id: "xzggs025.tve") [FAIL]
      System.AggregateException : One or more errors occurred. (One or more errors occurred. (A task was canceled.)) (The process cannot access the file '\\?\C:\helix\work\workitem\e\wbt\xzggs025.tve' because it is being used by another process.)
      ---- System.AggregateException : One or more errors occurred. (A task was canceled.)
      -------- System.Threading.Tasks.TaskCanceledException : A task was canceled.
      ---- System.IO.IOException : The process cannot access the file '\\?\C:\helix\work\workitem\e\wbt\xzggs025.tve' because it is being used by another process.

@lewing @radical any ideas?

@carlossanlop
Copy link
Member Author

carlossanlop commented Mar 21, 2023

@steveisok is that a new failure? If you think it is not related to this change, I can open an issue to track it separately, so I can unblock this PR. (From that error message you shared, it does not look very related to this change).

@steveisok
Copy link
Member

@steveisok is that a new failure? If you think it is not related to this change, I can open an issue to track it separately, so I can unblock this PR. (From that error message you shared, it does not look very related to this change).

I'm not sure if it's a new failure. I don't think the version bump is causing this, so can you make a known issue out of it?

@carlossanlop
Copy link
Member Author

CI failures:

@carlossanlop carlossanlop merged commit 60188fa into dotnet:main Mar 21, 2023
@carlossanlop carlossanlop deleted the BumpMainVersionToPrev4 branch March 21, 2023 21:44
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants