Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to enable native events in EventPipe #84318

Merged
merged 6 commits into from
Apr 14, 2023

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented Apr 4, 2023

Initial support for native event support to EventPipe, with GC events seen with the RuntimeProvider, that matches the existing EtwProvider support in NativeAOT.

Similar to the existing EtwProvider work in NativeAOT, the EventPipeProvider code is checked in, as opposed to using the python generated code. Unlike the EtwProvider, the code is in the opt-in EventPipe library (eventpipe-enabled.lib). There is corresponding minimal implementation in the disabled default EventPipe (eventpipe-disabled.lib).

Both managed and native events can be seen with tools like PerfView or dotnet-trace (collect option) by enabling the providers (in the native case, with Microsoft-Windows-DotNETRuntime for dotnet-trace and by selecting GC options in PerfView).

There will be a future effort to enhance the existing GC events with the right set of native events for NativeAOT.

@LakshanF
Copy link
Member Author

LakshanF commented Apr 9, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LakshanF
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but I'd like to see a signoff from someone actively working on NativeAOT as well.

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@LakshanF LakshanF merged commit 2d833f4 into dotnet:main Apr 14, 2023
@LakshanF LakshanF deleted the EventPipeNativeEvents2 branch April 14, 2023 11:26
@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants