Skip stp/ldp only for unwind portion of prolog/epilog #85657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis is the last portion remaining in #81278. We will now skip peephole optimizations only if we are generating code in unwind.
|
|
Diffs are great.
cc: @a74nh , @SwapnilGaikwad |
|
@dotnet/jit-contrib |
|
/azp run runtime-coreclr gcstress0x3-gcstress0xc, runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced May 2, 2023
|
@BruceForstall - I didn't realize that I didn't push a change that renames |
BruceForstall
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last portion remaining in #81278. We will do peephole optimizations of replacing
ldr/strwith pair instructionsldp/stpin prolog as well. We will skip the portion of the prolog where we are generating code for unwind.Fixes: #81278