Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] just skip the array type. #86290

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

shushanhf
Copy link
Contributor

@shushanhf shushanhf commented May 16, 2023

This PR is part of the issue #69705 to amend the LA's port.

The struct {int array[1]; float field_2;} which the array field is only one element,
just skip it although it can be passed by registers one integer and one float-register.
Details see github #62885 (comment)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 16, 2023
@shushanhf
Copy link
Contributor Author

Hi, @jkotas
Could you please review this PR?
Thanks

 The `struct {int array[1]; float field_2;}` which the array field is only one element,
 just skip it although it can be passed by registers one integer and one float-register.
 Details see github dotnet#62885 (comment)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit f452d9c into dotnet:main May 16, 2023
@shushanhf shushanhf deleted the Marshal_array branch May 17, 2023 01:01
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants