Remove incorrect flag setting #88878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
/azp run runtime-coreclr crossgen2 |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr crossgen2 |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr crossgen2 |
|
No commit pushedDate could be found for PR 88878 in repo dotnet/runtime |
This was referenced Jul 14, 2023
|
/azp run runtime-coreclr crossgen2 |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr crossgen2 |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr crossgen2 |
|
No commit pushedDate could be found for PR 88878 in repo dotnet/runtime |
MichalStrehovsky
force-pushed
the
MichalStrehovsky-patch-2
branch
from
9009978
to
47d69ae
Compare
|
/azp run runtime-coreclr crossgen2 |
|
No pipelines are associated with this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #85743 (comment). Setting this flag is not the right thing to do. It sweeps issues under the carpet. Also, we're only doing it for signature type variables, not method variable. And since no tests seem to be failing, it might not even be necessary.