Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect flag setting #88878

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Remove incorrect flag setting #88878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/coreclr/tools/Common/TypeSystem/Common/SignatureVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,16 @@ protected override TypeFlags ComputeTypeFlags(TypeFlags mask)
flags |= TypeFlags.SignatureTypeVariable;
}

flags |= TypeFlags.AttributeCacheComputed;
// ******************************************************
// Do not add other flags here. If you're hitting asserts
// because a flag wasn't set, this is a bug in the
// calling code. The fix is not here.
//
// The calling code is asking questions that are not
// possible to answer for signature variables
// (like: is this ByRef-like? We won't know until
// a substitution happens. Any answer would be wrong.)
// ******************************************************

return flags;
}
Expand Down Expand Up @@ -105,6 +114,17 @@ protected override TypeFlags ComputeTypeFlags(TypeFlags mask)
flags |= TypeFlags.SignatureMethodVariable;
}

// ******************************************************
// Do not add other flags here. If you're hitting asserts
// because a flag wasn't set, this is a bug in the
// calling code. The fix is not here.
//
// The calling code is asking questions that are not
// possible to answer for signature variables
// (like: is this ByRef-like? We won't know until
// a substitution happens. Any answer would be wrong.)
// ******************************************************

return flags;
}

Expand Down
Loading