Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Get/SetFieldValue to Account for EnC #90446

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Update Get/SetFieldValue to Account for EnC #90446

merged 3 commits into from
Aug 15, 2023

Conversation

mikelle-rogers
Copy link
Member

Fixes #76702

@mikelle-rogers mikelle-rogers self-assigned this Aug 12, 2023
@ghost
Copy link

ghost commented Aug 12, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76702

Author: mikelle-rogers
Assignees: mikelle-rogers
Labels:

area-Diagnostics-coreclr
Milestone: -

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Aug 12, 2023
View reviewed changes
src/coreclr/vm/invokeutil.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/invokeutil.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/invokeutil.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/invokeutil.cpp Outdated Show resolved Hide resolved
jkotas
jkotas approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mikelle-rogers mikelle-rogers merged commit 337e95e into dotnet:main Aug 15, 2023
@lambdageek
Copy link
Member

@mikelle-rogers sorry I didn't see this PR earlier. You should also remove the ActiveIssue here:

runtime/src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs

Line 326 in 337e95e

[ActiveIssue("https://github.com/dotnet/runtime/issues/76702", TestRuntimes.CoreCLR)]

@mikelle-rogers
Copy link
Member Author

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5870163775

@github-actions
Copy link
Contributor

@mikelle-rogers an error occurred while backporting to release/8.0-rc1, please check the run log for details!

Error: @mikelle-rogers is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=mikelle-rogers

@mikelle-rogers
Copy link
Member Author

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5870369270

@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Merged
@mikelle-rogers mikelle-rogers added this to the 8.0.0 milestone Aug 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@mikelle-rogers mikelle-rogers

Labels
area-Diagnostics-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[EnC] FieldInfo.GetValue on a newly-added ValueType field crashes CoreCLR
4 participants
@mikelle-rogers @lambdageek @jkotas @AaronRobinsonMSFT