Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update Get/SetFieldValue to Account for EnC #90623

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #90446 to release/8.0-rc1

/cc @mikelle-rogers

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@AaronRobinsonMSFT
Copy link
Member

Do you also want to address #90446 (comment) in this backport?

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in RC1

@carlossanlop
Copy link
Member

carlossanlop commented Aug 16, 2023

approved. we will take for consideration in RC1

With the recent RC guidance change, we need the template filled out and an email to Tactics requesting approval. @mikelle-rogers can you please do that?

Note: Please don't click on "Update branch". The CI will restart. I can bypass it and merge the PR for you.

@mikelle-rogers
Copy link
Member

We are putting this into RC2

@mikelle-rogers mikelle-rogers changed the title [release/8.0-rc1] Update Get/SetFieldValue to Account for EnC [release/8.0] Update Get/SetFieldValue to Account for EnC Aug 17, 2023
@mikelle-rogers mikelle-rogers changed the title [release/8.0] Update Get/SetFieldValue to Account for EnC [release/8.0-rc1] Update Get/SetFieldValue to Account for EnC Aug 17, 2023
@mikelle-rogers mikelle-rogers changed the base branch from release/8.0-rc1 to release/8.0 August 17, 2023 17:30
@mikelle-rogers mikelle-rogers changed the title [release/8.0-rc1] Update Get/SetFieldValue to Account for EnC [release/8.0] Update Get/SetFieldValue to Account for EnC Aug 17, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 17, 2023
@carlossanlop
Copy link
Member

Failure is known and unrelated: #90593

Since this is now targeting RC2, the current approvals are sufficient to merge.

@carlossanlop carlossanlop merged commit 515e5d1 into release/8.0 Aug 17, 2023
@carlossanlop carlossanlop deleted the backport/pr-90446-to-release/8.0-rc1 branch August 17, 2023 21:38
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants