-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from 10 repositories #90517
Merged
ViktorHofer
merged 43 commits into
main
from
darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
Aug 25, 2023
+353
−258
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
2b860da
Update dependencies from https://github.com/dotnet/runtime build 2023…
dotnet-maestro[bot] f55dffe
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] 54f661f
Update dependencies from https://github.com/dotnet/sdk build 20230814.3
dotnet-maestro[bot] 59be5c3
Don't use latest ILLink package
sbomer 8c0dbf1
Work around ProcessFrameworkReferences bug
sbomer 2de3e36
Update dependencies from https://github.com/dotnet/emsdk build 202308…
dotnet-maestro[bot] 2be781b
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] b736874
Update dependencies from https://github.com/dotnet/icu build 20230814.4
dotnet-maestro[bot] 67ff521
Update dependencies from https://github.com/dotnet/cecil build 202308…
dotnet-maestro[bot] bd9bd3a
Update dependencies from https://github.com/dotnet/sdk build 20230815.5
dotnet-maestro[bot] 46d6631
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] b63b6c4
Update dependencies from https://github.com/dotnet/sdk build 20230816.8
dotnet-maestro[bot] acca5d9
Attempt to fix test problems
sbomer 6426ab1
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] 6a90132
Update dependencies from https://github.com/dotnet/sdk build 20230817.3
dotnet-maestro[bot] 721edd3
Update dependencies from https://github.com/dotnet/sdk build 20230817.11
dotnet-maestro[bot] a0fc6ee
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 65ee9a5
Update dependencies from https://github.com/dotnet/sdk build 20230817.25
dotnet-maestro[bot] e398652
Add dotnet9* feeds
lewing f9b9ed1
Update dependencies from https://github.com/dotnet/runtime build 2023…
dotnet-maestro[bot] ba217ec
Update dependencies from https://github.com/dotnet/sdk build 20230818.40
dotnet-maestro[bot] 4b1a8ee
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 59c3db8
Update dependencies from https://github.com/dotnet/sdk build 20230819.8
dotnet-maestro[bot] b65d8fc
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] 7ae003a
Update dependencies from https://github.com/dotnet/sdk build 20230820.17
dotnet-maestro[bot] 704d0ed
Update dependencies from https://github.com/dotnet/runtime build 2023…
dotnet-maestro[bot] 1a4e047
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] caf5c66
Update dependencies from https://github.com/dotnet/icu build 20230821.1
dotnet-maestro[bot] 63d7883
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] 422e4e2
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] d629564
Update dependencies from https://github.com/dotnet/cecil build 202308…
dotnet-maestro[bot] e665bcb
Update dependencies from https://github.com/dotnet/sdk build 20230822.1
dotnet-maestro[bot] 89e129a
Merge branch 'main' into darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
akoeplinger 6c498c6
Remove unused parameter (https://github.com/dotnet/arcade/pull/13961)
akoeplinger 726b12f
Try to fix NativeAOT helix correlation payload issue
akoeplinger 53d3799
Revert a change
akoeplinger 734595b
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] 949836f
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] e5e460b
Update dependencies from https://github.com/dotnet/emsdk build 202308…
dotnet-maestro[bot] 4c1900f
Update dependencies from https://github.com/dotnet/sdk build 20230823.2
dotnet-maestro[bot] 2be61d1
Dependency coherency updates
dotnet-maestro[bot] e7fd0ef
Update dependencies from https://github.com/dotnet/sdk build 20230824.6
dotnet-maestro[bot] 7d3095e
Exclusion for Microsoft.NET.ILLink.Tasks
NikolaMilosavljevic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
<# | ||
.SYNOPSIS | ||
Install and run the 'Microsoft.DotNet.VersionTools.Cli' tool with the 'trim-artifacts-version' command to trim the version from the NuGet assets file name. | ||
|
||
.PARAMETER InputPath | ||
Full path to directory where artifact packages are stored | ||
|
||
.PARAMETER Recursive | ||
Search for NuGet packages recursively | ||
|
||
#> | ||
|
||
Param( | ||
[string] $InputPath, | ||
[bool] $Recursive = $true | ||
) | ||
|
||
$CliToolName = "Microsoft.DotNet.VersionTools.Cli" | ||
|
||
function Install-VersionTools-Cli { | ||
param( | ||
[Parameter(Mandatory=$true)][string]$Version | ||
) | ||
|
||
Write-Host "Installing the package '$CliToolName' with a version of '$version' ..." | ||
$feed = "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" | ||
|
||
$argumentList = @("tool", "install", "--local", "$CliToolName", "--add-source $feed", "--no-cache", "--version $Version", "--create-manifest-if-needed") | ||
Start-Process "$dotnet" -Verbose -ArgumentList $argumentList -NoNewWindow -Wait | ||
} | ||
|
||
# ------------------------------------------------------------------- | ||
|
||
if (!(Test-Path $InputPath)) { | ||
Write-Host "Input Path '$InputPath' does not exist" | ||
ExitWithExitCode 1 | ||
} | ||
|
||
$ErrorActionPreference = 'Stop' | ||
Set-StrictMode -Version 2.0 | ||
|
||
$disableConfigureToolsetImport = $true | ||
$global:LASTEXITCODE = 0 | ||
|
||
# `tools.ps1` checks $ci to perform some actions. Since the SDL | ||
# scripts don't necessarily execute in the same agent that run the | ||
# build.ps1/sh script this variable isn't automatically set. | ||
$ci = $true | ||
. $PSScriptRoot\..\tools.ps1 | ||
|
||
try { | ||
$dotnetRoot = InitializeDotNetCli -install:$true | ||
$dotnet = "$dotnetRoot\dotnet.exe" | ||
|
||
$toolsetVersion = Read-ArcadeSdkVersion | ||
Install-VersionTools-Cli -Version $toolsetVersion | ||
|
||
$cliToolFound = (& "$dotnet" tool list --local | Where-Object {$_.Split(' ')[0] -eq $CliToolName}) | ||
if ($null -eq $cliToolFound) { | ||
Write-PipelineTelemetryError -Force -Category 'Sdl' -Message "The '$CliToolName' tool is not installed." | ||
ExitWithExitCode 1 | ||
} | ||
|
||
Exec-BlockVerbosely { | ||
& "$dotnet" $CliToolName trim-assets-version ` | ||
--assets-path $InputPath ` | ||
--recursive $Recursive | ||
Exit-IfNZEC "Sdl" | ||
} | ||
} | ||
catch { | ||
Write-Host $_ | ||
Write-PipelineTelemetryError -Force -Category 'Sdl' -Message $_ | ||
ExitWithExitCode 1 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (
BundledNETCoreAppPackageVersion
in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).This packagereference is effectively equivalent to building with the SDK, with
<UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll validate full product build locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full source-build is showing 20 prebuilts but not the one for
Microsoft.Net.ILLink.Tasks
. I'm unsure about this - @MichaelSimonsHere's the full list of prebuilts:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one direct dependency coming from runtime
This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.