Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from 10 repositories #90517

Merged
merged 43 commits into from
Aug 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
2b860da
Update dependencies from https://github.com/dotnet/runtime build 2023…
dotnet-maestro[bot] Aug 14, 2023
f55dffe
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Aug 14, 2023
54f661f
Update dependencies from https://github.com/dotnet/sdk build 20230814.3
dotnet-maestro[bot] Aug 14, 2023
59be5c3
Don't use latest ILLink package
sbomer Aug 14, 2023
8c0dbf1
Work around ProcessFrameworkReferences bug
sbomer Aug 14, 2023
2de3e36
Update dependencies from https://github.com/dotnet/emsdk build 202308…
dotnet-maestro[bot] Aug 15, 2023
2be781b
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Aug 15, 2023
b736874
Update dependencies from https://github.com/dotnet/icu build 20230814.4
dotnet-maestro[bot] Aug 15, 2023
67ff521
Update dependencies from https://github.com/dotnet/cecil build 202308…
dotnet-maestro[bot] Aug 15, 2023
bd9bd3a
Update dependencies from https://github.com/dotnet/sdk build 20230815.5
dotnet-maestro[bot] Aug 15, 2023
46d6631
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Aug 16, 2023
b63b6c4
Update dependencies from https://github.com/dotnet/sdk build 20230816.8
dotnet-maestro[bot] Aug 16, 2023
acca5d9
Attempt to fix test problems
sbomer Aug 16, 2023
6426ab1
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] Aug 17, 2023
6a90132
Update dependencies from https://github.com/dotnet/sdk build 20230817.3
dotnet-maestro[bot] Aug 17, 2023
721edd3
Update dependencies from https://github.com/dotnet/sdk build 20230817.11
dotnet-maestro[bot] Aug 17, 2023
a0fc6ee
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Aug 18, 2023
65ee9a5
Update dependencies from https://github.com/dotnet/sdk build 20230817.25
dotnet-maestro[bot] Aug 18, 2023
e398652
Add dotnet9* feeds
lewing Aug 18, 2023
f9b9ed1
Update dependencies from https://github.com/dotnet/runtime build 2023…
dotnet-maestro[bot] Aug 19, 2023
ba217ec
Update dependencies from https://github.com/dotnet/sdk build 20230818.40
dotnet-maestro[bot] Aug 19, 2023
4b1a8ee
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Aug 20, 2023
59c3db8
Update dependencies from https://github.com/dotnet/sdk build 20230819.8
dotnet-maestro[bot] Aug 20, 2023
b65d8fc
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] Aug 21, 2023
7ae003a
Update dependencies from https://github.com/dotnet/sdk build 20230820.17
dotnet-maestro[bot] Aug 21, 2023
704d0ed
Update dependencies from https://github.com/dotnet/runtime build 2023…
dotnet-maestro[bot] Aug 21, 2023
1a4e047
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Aug 21, 2023
caf5c66
Update dependencies from https://github.com/dotnet/icu build 20230821.1
dotnet-maestro[bot] Aug 22, 2023
63d7883
Update dependencies from https://github.com/dotnet/xharness build 202…
dotnet-maestro[bot] Aug 22, 2023
422e4e2
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] Aug 22, 2023
d629564
Update dependencies from https://github.com/dotnet/cecil build 202308…
dotnet-maestro[bot] Aug 22, 2023
e665bcb
Update dependencies from https://github.com/dotnet/sdk build 20230822.1
dotnet-maestro[bot] Aug 22, 2023
89e129a
Merge branch 'main' into darc-main-24d23629-0a47-41d9-bbc9-f3145469db0c
akoeplinger Aug 23, 2023
6c498c6
Remove unused parameter (https://github.com/dotnet/arcade/pull/13961)
akoeplinger Aug 23, 2023
726b12f
Try to fix NativeAOT helix correlation payload issue
akoeplinger Aug 23, 2023
53d3799
Revert a change
akoeplinger Aug 23, 2023
734595b
Update dependencies from https://github.com/dotnet/arcade build 20230…
dotnet-maestro[bot] Aug 23, 2023
949836f
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] Aug 23, 2023
e5e460b
Update dependencies from https://github.com/dotnet/emsdk build 202308…
dotnet-maestro[bot] Aug 23, 2023
4c1900f
Update dependencies from https://github.com/dotnet/sdk build 20230823.2
dotnet-maestro[bot] Aug 23, 2023
2be61d1
Dependency coherency updates
dotnet-maestro[bot] Aug 23, 2023
e7fd0ef
Update dependencies from https://github.com/dotnet/sdk build 20230824.6
dotnet-maestro[bot] Aug 24, 2023
7d3095e
Exclusion for Microsoft.NET.ILLink.Tasks
NikolaMilosavljevic Aug 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
]
},
"microsoft.dotnet.xharness.cli": {
"version": "8.0.0-prerelease.23407.2",
"version": "8.0.0-prerelease.23421.1",
"commands": [
"xharness"
]
Expand Down
2 changes: 2 additions & 0 deletions NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
<add key="dotnet-libraries-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries-transport/nuget/v3/index.json" />
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />
<add key="dotnet8-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8-transport/nuget/v3/index.json" />
<add key="dotnet9" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json" />
<add key="dotnet9-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9-transport/nuget/v3/index.json" />
</packageSources>
<disabledPackageSources>
<clear />
Expand Down
3 changes: 3 additions & 0 deletions eng/SourceBuildPrebuiltBaseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
<UsagePattern IdentityGlob="Microsoft.NETCore.App.Runtime.linux-x64/*8.*" />
<UsagePattern IdentityGlob="*Microsoft.DotNet.ILCompiler/*8.*" />

<!-- Allowed and pinned to SDK version -->
<UsagePattern IdentityGlob="Microsoft.NET.ILLink.Tasks/*8.*" />

<!-- Will be removed once https://github.com/NuGet/Home/issues/11059 is resolved -->
<UsagePattern IdentityGlob="Nuget.*/*" />

Expand Down
316 changes: 158 additions & 158 deletions eng/Version.Details.xml

Large diffs are not rendered by default.

147 changes: 73 additions & 74 deletions eng/Versions.props

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions eng/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,12 @@ initDistroRid()
local targetOs="$1"
local targetArch="$2"
local isCrossBuild="$3"
local isPortableBuild="$4"

# Only pass ROOTFS_DIR if __DoCrossArchBuild is specified and the current platform is not an Apple platform (that doesn't use rootfs)
if [[ $isCrossBuild == 1 && "$targetOs" != "osx" && "$targetOs" != "ios" && "$targetOs" != "iossimulator" && "$targetOs" != "tvos" && "$targetOs" != "tvossimulator" && "$targetOs" != "maccatalyst" ]]; then
passedRootfsDir=${ROOTFS_DIR}
fi
initDistroRidGlobal "${targetOs}" "${targetArch}" "${isPortableBuild}" "${passedRootfsDir}"
initDistroRidGlobal "${targetOs}" "${targetArch}" "${passedRootfsDir}"
}

showSubsetHelp()
Expand Down Expand Up @@ -549,7 +548,7 @@ if [[ "${TreatWarningsAsErrors:-}" == "false" ]]; then
arguments="$arguments -warnAsError 0"
fi

initDistroRid "$os" "$arch" "$crossBuild" "$portableBuild"
initDistroRid "$os" "$arch" "$crossBuild"

# Disable targeting pack caching as we reference a partially constructed targeting pack and update it later.
# The later changes are ignored when using the cache.
Expand Down
2 changes: 1 addition & 1 deletion eng/common/SetupNugetSources.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ if ($dotnet31Source -ne $null) {
AddPackageSource -Sources $sources -SourceName "dotnet3.1-internal-transport" -SourceEndPoint "https://pkgs.dev.azure.com/dnceng/_packaging/dotnet3.1-internal-transport/nuget/v2" -Creds $creds -Username $userName -Password $Password
}

$dotnetVersions = @('5','6','7')
$dotnetVersions = @('5','6','7','8')

foreach ($dotnetVersion in $dotnetVersions) {
$feedPrefix = "dotnet" + $dotnetVersion;
Expand Down
2 changes: 1 addition & 1 deletion eng/common/SetupNugetSources.sh
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ if [ "$?" == "0" ]; then
PackageSources+=('dotnet3.1-internal-transport')
fi

DotNetVersions=('5' '6' '7')
DotNetVersions=('5' '6' '7' '8')

for DotNetVersion in ${DotNetVersions[@]} ; do
FeedPrefix="dotnet${DotNetVersion}";
Expand Down
Binary file modified eng/common/loc/P22DotNetHtmlLocalization.lss
Binary file not shown.
2 changes: 1 addition & 1 deletion eng/common/native/init-compiler.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ if [ -z "$CLR_CC" ]; then
# Set default versions
if [ -z "$majorVersion" ]; then
# note: gcc (all versions) and clang versions higher than 6 do not have minor version in file name, if it is zero.
if [ "$compiler" = "clang" ]; then versions="16 15 14 13 12 11 10 9 8 7 6.0 5.0 4.0 3.9 3.8 3.7 3.6 3.5"
if [ "$compiler" = "clang" ]; then versions="17 16 15 14 13 12 11 10 9 8 7 6.0 5.0 4.0 3.9 3.8 3.7 3.6 3.5"
elif [ "$compiler" = "gcc" ]; then versions="13 12 11 10 9 8 7 6 5 4.9"; fi

for version in $versions; do
Expand Down
6 changes: 2 additions & 4 deletions eng/common/native/init-distro-rid.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ getNonPortableDistroRid()
# Input:
# os: (str)
# arch: (str)
# isPortable: (int)
# rootfsDir?: (nullable:string)
#
# Return:
Expand All @@ -97,10 +96,9 @@ initDistroRidGlobal()
{
local targetOs="$1"
local targetArch="$2"
local isPortable="$3"
local rootfsDir=""
if [ "$#" -ge 4 ]; then
rootfsDir="$4"
if [ "$#" -ge 3 ]; then
rootfsDir="$3"
fi

if [ -n "${rootfsDir}" ]; then
Expand Down
75 changes: 75 additions & 0 deletions eng/common/sdl/trim-assets-version.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
<#
.SYNOPSIS
Install and run the 'Microsoft.DotNet.VersionTools.Cli' tool with the 'trim-artifacts-version' command to trim the version from the NuGet assets file name.

.PARAMETER InputPath
Full path to directory where artifact packages are stored

.PARAMETER Recursive
Search for NuGet packages recursively

#>

Param(
[string] $InputPath,
[bool] $Recursive = $true
)

$CliToolName = "Microsoft.DotNet.VersionTools.Cli"

function Install-VersionTools-Cli {
param(
[Parameter(Mandatory=$true)][string]$Version
)

Write-Host "Installing the package '$CliToolName' with a version of '$version' ..."
$feed = "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json"

$argumentList = @("tool", "install", "--local", "$CliToolName", "--add-source $feed", "--no-cache", "--version $Version", "--create-manifest-if-needed")
Start-Process "$dotnet" -Verbose -ArgumentList $argumentList -NoNewWindow -Wait
}

# -------------------------------------------------------------------

if (!(Test-Path $InputPath)) {
Write-Host "Input Path '$InputPath' does not exist"
ExitWithExitCode 1
}

$ErrorActionPreference = 'Stop'
Set-StrictMode -Version 2.0

$disableConfigureToolsetImport = $true
$global:LASTEXITCODE = 0

# `tools.ps1` checks $ci to perform some actions. Since the SDL
# scripts don't necessarily execute in the same agent that run the
# build.ps1/sh script this variable isn't automatically set.
$ci = $true
. $PSScriptRoot\..\tools.ps1

try {
$dotnetRoot = InitializeDotNetCli -install:$true
$dotnet = "$dotnetRoot\dotnet.exe"

$toolsetVersion = Read-ArcadeSdkVersion
Install-VersionTools-Cli -Version $toolsetVersion

$cliToolFound = (& "$dotnet" tool list --local | Where-Object {$_.Split(' ')[0] -eq $CliToolName})
if ($null -eq $cliToolFound) {
Write-PipelineTelemetryError -Force -Category 'Sdl' -Message "The '$CliToolName' tool is not installed."
ExitWithExitCode 1
}

Exec-BlockVerbosely {
& "$dotnet" $CliToolName trim-assets-version `
--assets-path $InputPath `
--recursive $Recursive
Exit-IfNZEC "Sdl"
}
}
catch {
Write-Host $_
Write-PipelineTelemetryError -Force -Category 'Sdl' -Message $_
ExitWithExitCode 1
}
5 changes: 5 additions & 0 deletions eng/common/templates/job/execute-sdl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ jobs:
downloadPath: $(Build.ArtifactStagingDirectory)\artifacts
checkDownloadedFiles: true

- powershell: eng/common/sdl/trim-assets-version.ps1
-InputPath $(Build.ArtifactStagingDirectory)\artifacts
displayName: Trim the version from the NuGet packages
continueOnError: ${{ parameters.sdlContinueOnError }}

- powershell: eng/common/sdl/extract-artifact-packages.ps1
-InputPath $(Build.ArtifactStagingDirectory)\artifacts\BlobArtifacts
-ExtractPath $(Build.ArtifactStagingDirectory)\artifacts\BlobArtifacts
Expand Down
6 changes: 5 additions & 1 deletion eng/common/tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -671,14 +671,18 @@ function InitializeNativeTools() {
}
}

function Read-ArcadeSdkVersion() {
return $GlobalJson.'msbuild-sdks'.'Microsoft.DotNet.Arcade.Sdk'
}

function InitializeToolset() {
if (Test-Path variable:global:_ToolsetBuildProj) {
return $global:_ToolsetBuildProj
}

$nugetCache = GetNuGetPackageCachePath

$toolsetVersion = $GlobalJson.'msbuild-sdks'.'Microsoft.DotNet.Arcade.Sdk'
$toolsetVersion = Read-ArcadeSdkVersion
$toolsetLocationFile = Join-Path $ToolsetDir "$toolsetVersion.txt"

if (Test-Path $toolsetLocationFile) {
Expand Down
19 changes: 15 additions & 4 deletions eng/illink.targets
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

<PropertyGroup>
<IsTrimmable Condition="'$(IsTrimmable)' == ''">true</IsTrimmable>
<!-- Don't use SDK's trimming functionality.
TODO: Remove this once we build using preview 6 SDK. -->
<_IsTrimmingEnabled>false</_IsTrimmingEnabled>
<!-- Same fix for preview 6 SDK. -->
<!-- Don't use SDK's trimming functionality.
Once we have an SDK with
https://github.com/dotnet/sdk/commit/bdce224bba472ccad4bade07b757ac5275040c0e
and
https://github.com/dotnet/sdk/commit/f051b536cc12190488231f3a889df44214c1bc2e,
we might be able to use built-in functionality instead of a packagereference.
-->
<_RequiresILLinkPack>false</_RequiresILLinkPack>
<PrepareResourcesDependsOn>_EmbedILLinkXmls;$(PrepareResourcesDependsOn)</PrepareResourcesDependsOn>
<TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'">$(TargetsTriggeredByCompilation);ILLinkTrimAssembly</TargetsTriggeredByCompilation>
Expand Down Expand Up @@ -40,6 +43,14 @@
<GenerateResourcesSubstitutions Condition="'$(GenerateResourcesSubstitutions)' == '' and '$(StringResourcesPath)' != ''">true</GenerateResourcesSubstitutions>
</PropertyGroup>

<!-- Use ILLink.Tasks version matching the SDK used to build. See comment about _RequiresILLinkPack. -->
<PropertyGroup>
<SuppressILLinkExplicitPackageReferenceWarning>true</SuppressILLinkExplicitPackageReferenceWarning>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.ILLink.Tasks" Version="$(BundledNETCoreAppPackageVersion)" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
<ILLinkSuppressionsXmls Include="$(ILLinkSuppressionsXmlFile)"
Condition="Exists('$(ILLinkSuppressionsXmlFile)')" />
Expand Down
2 changes: 1 addition & 1 deletion eng/native/build-commons.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ initTargetDistroRid()
passedRootfsDir="$ROOTFS_DIR"
fi

initDistroRidGlobal "$__TargetOS" "$__TargetArch" "$__PortableBuild" "$passedRootfsDir"
initDistroRidGlobal "$__TargetOS" "$__TargetArch" "$passedRootfsDir"
}

setup_dirs()
Expand Down
8 changes: 4 additions & 4 deletions global.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"dotnet": "8.0.100-preview.7.23376.3"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "8.0.0-beta.23411.1",
"Microsoft.DotNet.Helix.Sdk": "8.0.0-beta.23411.1",
"Microsoft.DotNet.SharedFramework.Sdk": "8.0.0-beta.23411.1",
"Microsoft.DotNet.Arcade.Sdk": "8.0.0-beta.23422.1",
"Microsoft.DotNet.Helix.Sdk": "8.0.0-beta.23422.1",
"Microsoft.DotNet.SharedFramework.Sdk": "8.0.0-beta.23422.1",
"Microsoft.Build.NoTargets": "3.7.0",
"Microsoft.Build.Traversal": "3.4.0",
"Microsoft.NET.Sdk.IL": "8.0.0-rc.1.23406.6"
"Microsoft.NET.Sdk.IL": "8.0.0-rc.1.23421.1"
}
}
3 changes: 2 additions & 1 deletion src/libraries/sendtohelix-mobile.targets
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
<_XHarnessAppleCustomCommand Condition="'$(NeedsiOSSDK)' == 'true'">
source build-apple-app.sh
</_XHarnessAppleCustomCommand>
<ILLinkDir>$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.net.illink.tasks', '$(MicrosoftNETILLinkTasksVersion)'))</ILLinkDir>
<!-- Use ILLink.Tasks version matching the SDK used to build. See comment about _RequiresILLinkPack in eng/illink.targets -->
<ILLinkDir>$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)', 'microsoft.net.illink.tasks', '$(BundledNETCoreAppPackageVersion)'))</ILLinkDir>
</PropertyGroup>

<ItemGroup Condition="'$(NeedsiOSSDK)' == 'true'">
Expand Down
2 changes: 2 additions & 0 deletions src/tests/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<LibrariesConfiguration>Release</LibrariesConfiguration>
<!-- NativeAot tests rely on presence of ILLink targets, but don't actually run ILLink. -->
<UsingToolMicrosoftNetILLinkTasks Condition="'$(UsingToolMicrosoftNetILLinkTasks)' == ''">true</UsingToolMicrosoftNetILLinkTasks>
</PropertyGroup>

<Import Project="$(MSBuildThisFileDirectory)\Common\dir.sdkbuild.props" Condition="'$(UsingMicrosoftNETSdk)' == 'true'" />
Expand Down
4 changes: 0 additions & 4 deletions src/tools/illink/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<Project>
<PropertyGroup>
<!-- Don't use the prebuilt illink that is referenced by Arcade. -->
<UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>
</PropertyGroup>
Comment on lines -2 to -5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of source-build failure. It is causing the usage of prebuilt version of Microsoft.Net.ILLink.Tasks package. Is this accidental? @akoeplinger @vikoeplinger

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes intentionally use the version of ILLink.Tasks that is referenced by the SDK in global.json (BundledNETCoreAppPackageVersion in https://github.com/dotnet/runtime/pull/90517/files#diff-361b24a1b39d592c236441b48457113d003aeb3bc03df5bbc0318fd0b2e05cd2R50-R53).

This packagereference is effectively equivalent to building with the SDK, with <UsingToolMicrosoftNetILLinkTasks>false</UsingToolMicrosoftNetILLinkTasks>. The packagereference was required as a workaround (see these comments), but I'd expect that for the purpose of source-build it is no different.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.

I'll validate full product build locally.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this would would in the product source-build because the ILLink version we have in n-1 artifacts would be coherent with the SDK we use to build therefore it wouldn't be a prebuilt. During the repo leg this may need to be marked as an allowed prebuilt. This full product source build should be validated.

I'll validate full product build locally.

Full source-build is showing 20 prebuilts but not the one for Microsoft.Net.ILLink.Tasks. I'm unsure about this - @MichaelSimons

Here's the full list of prebuilts:

    <Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="Microsoft.CodeAnalysis.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="Microsoft.CodeAnalysis.CSharp" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />
    <Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="Microsoft.Extensions.DependencyInjection" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
    <Usage Id="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
    <Usage Id="Microsoft.Extensions.Logging" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
    <Usage Id="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" IsDirectDependency="true" />
    <Usage Id="Microsoft.Extensions.Options" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
    <Usage Id="Microsoft.Extensions.Primitives" Version="8.0.0-rc.1.23414.4" File="src/sdk/artifacts/source-build/self/src/artifacts/obj/Microsoft.NET.Build.Containers/project.assets.json" />
    <Usage Id="Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
    <Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net6.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
    <Usage Id="Microsoft.NET.Workload.Mono.ToolChain.net7.Manifest-8.0.100-rc.1" Version="8.0.0-rc.1.23414.4" />
    <Usage Id="System.Composition" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="System.Composition.AttributedModel" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="System.Composition.Convention" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="System.Composition.Hosting" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="System.Composition.Runtime" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />
    <Usage Id="System.Composition.TypedParts" Version="7.0.0" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime

<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one direct dependency coming from runtime

<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.7.0-3.23314.3" File="src/runtime/artifacts/source-build/self/src/artifacts/obj/Microsoft.Extensions.Configuration.Binder.SourceGeneration/project.assets.json" IsDirectDependency="true" />

This is a result of #90340 which was addressed in #91006. I suspect the commit tested didn't have the fix. I think the test has proven this will not introduce a prebuilt in the product level source-build.

Thanks - I'll work on a fix to add exclusion for ILLink.Tasks.


<Import Project="..\..\..\Directory.Build.props" />

Expand Down