Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MicrosoftCodeAnalysisVersion_LatestVS version to 4.7.0 #91006

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Aug 23, 2023

In #90340 (for main/.NET9) the config binding generator alone upgraded to 4.7.0, required to use the interceptors feature. This PR applies the upgrade to the entire repo to avoid source-build pre-built issues.

Fixes #90849.

@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

In #90340 (for main/.NET9) the config binding generators singularly upgraded to 4.7.0, required to use the interceptors feature. This PR applies the upgrade to the entire repo to avoid source-build pre-built issues.

Fixes #90849.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration

Milestone: 9.0.0

@layomia layomia requested a review from sbomer as a code owner August 23, 2023 20:00
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you open the issues for the analyzer failures in the mentioned areas and add the links to this PR before merging?

@layomia layomia merged commit c4f8c3b into dotnet:main Aug 24, 2023
186 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the Microsoft.CodeAnalysis.* version to use compiler interceptors for source gen
3 participants