Add regression test for GitHub issue #74132 #91009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have verified locally that the problem described in the issue no longer exists in .NET 8 RC1, the bug was probably fixed earlier this year by David Wrighton. I think the regression test described in the issue is useful so I'm proposing to merge it in; this PR will then close the issue. Fixes: dotnet#74132 Thanks Tomas
ghost
assigned 
|
I assume the specific-issue regression tests will remain in the old testing system? As in, the executable directly rather than the Fact/Theory thingies? |
jkotas
reviewed
Aug 23, 2023
|
|
||
| using System; | ||
|
|
||
| // This regression test tracks the issue where GetInterfaceMap returns incorrect |
There was a problem hiding this comment.
This is regression test for a BCL API behavior. It would be more appropriate to add it under src\libraries, similar to #90518 - if this case is not covered by the tests being added already.
There was a problem hiding this comment.
OK, thanks for pointing that out, in such case I'll abandon this PR and I'll follow up on the #90518 PR thread.
|
Closing per JanK's PR feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified locally that the problem described in the issue no longer exists in .NET 8 RC1, the bug was probably fixed earlier this year by David Wrighton. I think the regression test described in the issue is useful so I'm proposing to merge it in; this PR will then close the issue.
Fixes: #74132
Thanks
Tomas