-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for GitHub issue #74132 #91009
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
src/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_74132.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System; | ||
|
||
// This regression test tracks the issue where GetInterfaceMap returns incorrect | ||
// non-generic entries for generic static virtual methods. | ||
|
||
public interface I<T> where T : I<T> | ||
{ | ||
public void Instance<M>(M m); | ||
public static abstract void Static<M>(M m); | ||
} | ||
|
||
public readonly struct C : I<C> | ||
{ | ||
public void Instance<M>(M m) { } | ||
public static void Static<M>(M m) { } | ||
} | ||
|
||
internal class Program | ||
{ | ||
static int Main(string[] args) | ||
{ | ||
var interfaceMap = typeof(C).GetInterfaceMap(typeof(I<C>)); | ||
bool allMethodsAreGeneric = true; | ||
for (int i = 0; i < interfaceMap.InterfaceMethods.Length; i++) | ||
{ | ||
var imethod = interfaceMap.InterfaceMethods[i]; | ||
var tmethod = interfaceMap.TargetMethods[i]; | ||
Console.WriteLine($"Interface.{imethod.Name} is generic method def: {imethod.IsGenericMethodDefinition}"); | ||
Console.WriteLine($"Target.{tmethod.Name} is generic method def: {tmethod.IsGenericMethodDefinition}"); | ||
if (!imethod.IsGenericMethodDefinition || !tmethod.IsGenericMethodDefinition) | ||
{ | ||
allMethodsAreGeneric = false; | ||
} | ||
} | ||
|
||
if (!allMethodsAreGeneric) | ||
{ | ||
throw new Exception("Test failed, all above methods should be reported as generic!"); | ||
} | ||
|
||
return 100; | ||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
src/tests/Loader/classloader/StaticVirtualMethods/Regression/GitHub_74132.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
<OutputType>Exe</OutputType> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<Compile Include="$(MSBuildProjectName).cs" /> | ||
</ItemGroup> | ||
</Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is regression test for a BCL API behavior. It would be more appropriate to add it under src\libraries, similar to #90518 - if this case is not covered by the tests being added already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for pointing that out, in such case I'll abandon this PR and I'll follow up on the #90518 PR thread.