Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for GitHub issue #74132 #91009

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;

// This regression test tracks the issue where GetInterfaceMap returns incorrect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is regression test for a BCL API behavior. It would be more appropriate to add it under src\libraries, similar to #90518 - if this case is not covered by the tests being added already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for pointing that out, in such case I'll abandon this PR and I'll follow up on the #90518 PR thread.

// non-generic entries for generic static virtual methods.

public interface I<T> where T : I<T>
{
public void Instance<M>(M m);
public static abstract void Static<M>(M m);
}

public readonly struct C : I<C>
{
public void Instance<M>(M m) { }
public static void Static<M>(M m) { }
}

internal class Program
{
static int Main(string[] args)
{
var interfaceMap = typeof(C).GetInterfaceMap(typeof(I<C>));
bool allMethodsAreGeneric = true;
for (int i = 0; i < interfaceMap.InterfaceMethods.Length; i++)
{
var imethod = interfaceMap.InterfaceMethods[i];
var tmethod = interfaceMap.TargetMethods[i];
Console.WriteLine($"Interface.{imethod.Name} is generic method def: {imethod.IsGenericMethodDefinition}");
Console.WriteLine($"Target.{tmethod.Name} is generic method def: {tmethod.IsGenericMethodDefinition}");
if (!imethod.IsGenericMethodDefinition || !tmethod.IsGenericMethodDefinition)
{
allMethodsAreGeneric = false;
}
}

if (!allMethodsAreGeneric)
{
throw new Exception("Test failed, all above methods should be reported as generic!");
}

return 100;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<OutputType>Exe</OutputType>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
</Project>