Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Switch macOS to mmap thunks like iOS platforms #91751

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[NativeAOT] Switch macOS to mmap thunks like iOS platforms #91751

merged 1 commit into from
Sep 13, 2023

Conversation

filipnavara
Copy link
Member

Fixes #91738

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 7, 2023
@ghost
Copy link

ghost commented Sep 7, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #91738

Author: filipnavara
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Sep 7, 2023
Closed
@filipnavara filipnavara marked this pull request as ready for review September 8, 2023 14:36
@jkotas jkotas merged commit d34ed28 into dotnet:main Sep 13, 2023
106 of 108 checks passed
@jkotas
Copy link
Member

jkotas commented Sep 13, 2023

Thank you!

@MichalPetryka
Copy link
Contributor

Does backporting this to 8.0 make sense?

@jkotas
Copy link
Member

jkotas commented Sep 15, 2023

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6200734979

@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Merged
@jkotas
Copy link
Member

jkotas commented Sep 15, 2023

Does backporting this to 8.0 make sense?

@MichalPetryka Thank you for pointing this out. The fix has been backported to .NET 8 RC2.

@filipnavara filipnavara deleted the macos-mapped-thunks branch September 16, 2023 04:55
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NativeAOT] Thunk mapping doesn't work on macOS/x64 with hardened runtime
3 participants
@filipnavara @jkotas @MichalPetryka