Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [NativeAOT] Switch macOS to mmap thunks like iOS platforms #92136

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 15, 2023

Backport of #91751 to release/8.0

/cc @jkotas @filipnavara

Customer Impact

Apps published as native AOT do not work with hardened runtime on macOS. It is regression relative to regular CoreCLR w/ JIT that prevents native AOT compiled apps from being published on the app store.

Testing

Ad hoc testing.

Risk

Medium. The change itself is small, but it enables hundreds of lines of low-level code. that have been used for iOS.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 15, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91751 to release/8.0

/cc @jkotas @filipnavara

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. this can be merged when ready

@carlossanlop carlossanlop added the Servicing-consider Issue for next servicing release review label Sep 15, 2023
@carlossanlop carlossanlop added this to the 8.0.0 milestone Sep 15, 2023
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 15, 2023
@carlossanlop
Copy link
Member

@filipnavara @jkotas there is a NativeAOT failure in osx-x64. Is it related to this change? https://github.com/dotnet/runtime/pull/92136/checks?check_run_id=16837406532

@agocke
Copy link
Member

agocke commented Sep 15, 2023

Looks like this change very slightly increases the size of the executable. I assume that's expected? Because we now have to reserve a page for the thunks?

@jkotas
Copy link
Member

jkotas commented Sep 15, 2023

Yes, it is expected. We have not seen this issue in main because of it has other size reducing changes.

@jkotas jkotas merged commit f262154 into release/8.0 Sep 15, 2023
119 checks passed
@jkotas jkotas deleted the backport/pr-91751-to-release/8.0 branch September 15, 2023 20:51
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants