Use strategy in StrategyBasedComWrappers.ComputeVtables #92085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't actually use the strategy object here, so users like WinForms can't actually use it.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
jtschuster and
elinor-fung
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsWe didn't actually use the strategy object here, so users like WinForms can't actually use it to override behavior. This is stopping WinForms from onboarding to StrategyBasedComWrappers. I think this is worth backporting to 8.0 as the fixed bug significantly limits the utility of other RCW/CCW systems' ability to interact with source-generated COM.
|
jtschuster
reviewed
Sep 14, 2023
...e.InteropServices/src/System/Runtime/InteropServices/Marshalling/StrategyBasedComWrappers.cs
Outdated
Show resolved
Hide resolved
…e/InteropServices/Marshalling/StrategyBasedComWrappers.cs Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com>
AaronRobinsonMSFT
approved these changes
Sep 15, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6228779814 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't actually use the strategy object here, so users like WinForms can't actually use it to override behavior. This is stopping WinForms from onboarding to StrategyBasedComWrappers.
I think this is worth backporting to 8.0 as the fixed bug significantly limits the utility of other RCW/CCW systems' ability to interact with source-generated COM.