-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Use strategy in StrategyBasedComWrappers.ComputeVtables #92250
Conversation
We didn't actually use the strategy object here, so users like WinForms can't actually use it.
…e/InteropServices/Marshalling/StrategyBasedComWrappers.cs Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com>
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsBackport of #92085 to release/8.0 /cc @jkoritzinsky Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. @carlossanlop
Wow the CI is taking forever on this PR 😢 |
Backport of #92085 to release/8.0
/cc @jkoritzinsky
Customer Impact
Customers cannot customize CCW behavior as designed in source-generated COM interop.
Testing
Validated with unit tests.
Risk
Low risk. The change just calls a method that ends up doing the exact same behavior as today.