Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining set of TensorPrimitives APIs for .NET 8 #92154

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Add remaining set of TensorPrimitives APIs for .NET 8 #92154

merged 3 commits into from
Sep 16, 2023

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Sep 15, 2023 •
edited
Loading

Represents the last planned .NET 8 surface area for TensorPrimitives (but not the last PR to improve it).

Adds non-vectorized implementations of:

  • Max
  • MaxMagnitude
  • IndexOfMax
  • IndexOfMaxMagnitude
  • Min
  • MinMagnitude
  • IndexOfMin
  • IndexOfMinMagnitude
  • ConvertToHalf (only on .NET Core)
  • ConvertToSingle (only on .NET Core)

Adds vectorized implementations of:

  • Sum
  • SumOfSquares
  • SumOfMagnitudes
  • Product
  • ProductOfSums
  • ProductOfDifferences

Vectorizes the implementations of:

  • CosineSimilarity
  • Distance
  • L2Normalize
  • Dot

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:

  • Handling alignment better
  • Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned stephentoub Sep 15, 2023
@ghost
Copy link

ghost commented Sep 15, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

With #92142, represents the last planned .NET 8 surface area for TensorPrimitives (but not the last PR to improve it).

Adds non-vectorized implementations of:

  • Max
  • Min
  • MaxMagnitude
  • MinMagnitude
  • IndexOfMax
  • IndexOfMin
  • IndexOfMaxMagnitude
  • ConvertToHalf (only on .NET Core)
  • ConvertToSingle (only on .NET Core)
  • IndexOfMinMagnitude

Adds vectorized implementations of:

  • Sum
  • SumOfSquares
  • SumOfMagnitudes
  • Product
  • ProductOfSums
  • ProductOfDifferences

Also includes the helpers that'll make it trivial to vectorize Dot.

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:

  • Handling alignment better
  • Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar
Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Numerics, new-api-needs-documentation
Milestone: -

gfoidl
gfoidl reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just scrolled over it...

src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Outdated Show resolved Hide resolved
...ibraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs Outdated Show resolved Hide resolved
@stephentoub stephentoub force-pushed the finaltensorprimitivesapis branch from b2c1deb to a593e1c Compare September 15, 2023 21:20
@stephentoub stephentoub mentioned this pull request Sep 15, 2023
Merged
@stephentoub
Add remaining set of TensorPrimitives APIs for .NET 8
14ac04d 
Adds non-vectorized implementations of:
- Max
- Min
- MaxMagnitude
- MinMagnitude
- IndexOfMax
- IndexOfMin
- IndexOfMaxMagnitude
- ConvertToHalf (only on .NET Core)
- ConvertToSingle (only on .NET Core)
- IndexOfMinMagnitude

Adds vectorized implementations of:
- Sum
- SumOfSquares
- SumOfMagnitudes
- Product
- ProductOfSums
- ProductOfDifferences

Also includes the helpers that'll make it trivial to vectorize Dot.

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:
- Handling alignment better
- Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar
@stephentoub stephentoub force-pushed the finaltensorprimitivesapis branch from a593e1c to a1cc407 Compare September 16, 2023 01:06
ericstj
ericstj approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have skimmed these where I understand them - did my best on the vectorized methods. Can't find any issues. :shipit:

gfoidl
gfoidl reviewed Sep 16, 2023
View reviewed changes
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Outdated Show resolved Hide resolved
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Outdated Show resolved Hide resolved
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Outdated Show resolved Hide resolved
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Outdated Show resolved Hide resolved
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Show resolved Hide resolved
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netcore.cs Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Sep 16, 2023
Closed
@stephentoub stephentoub merged commit f5cff04 into dotnet:main Sep 16, 2023
189 checks passed
@stephentoub stephentoub deleted the finaltensorprimitivesapis branch September 16, 2023 19:32
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request Sep 18, 2023
@stephentoub @michaelgsharp
Add remaining set of TensorPrimitives APIs for .NET 8 (dotnet#92154)
6eb4ed5 
* Add remaining set of TensorPrimitives APIs for .NET 8

Adds non-vectorized implementations of:
- Max
- Min
- MaxMagnitude
- MinMagnitude
- IndexOfMax
- IndexOfMin
- IndexOfMaxMagnitude
- ConvertToHalf (only on .NET Core)
- ConvertToSingle (only on .NET Core)
- IndexOfMinMagnitude

Adds vectorized implementations of:
- Sum
- SumOfSquares
- SumOfMagnitudes
- Product
- ProductOfSums
- ProductOfDifferences

Also includes the helpers that'll make it trivial to vectorize Dot.

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:
- Handling alignment better
- Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar

* Cleanup after previous PR, vectorize CosineSimilarity/Dot/L2Normalize/Distance, add tests

* Address PR feedback, and fix a few other issues
ericstj pushed a commit that referenced this pull request Sep 19, 2023
@michaelgsharp @tannergooding
@ViktorHofer @stephentoub @tmds
[release/8.0] Numerics and Tensors backport (#92245)
4b7c754 
* added Bcl.Numerics

* Adding a naive implementation of various primitive tensor operations (#91228)

* Adding a naive implementation of various primitive tensor operations

* Adding tests covering the new tensor primitives APIs

* Adding tensor primitives APIs to the ref assembly

* Allow .NET Framework to build/run

* Sync TFMs between ref and src, csproj simplication and clean-up

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* Don't use var

* Fix the S.N.Tensors readme and remove the file marking it as non-shipping

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>

* Start vectorizing TensorPrimitives (#91596)

* Start vectorizing TensorPrimitives

Just does two functions to establish the files into which the rest of the implementations can be moved.

* 6 more naive methods for Tensor Primitives. (#92142)

* 6 more naive methods

* updates from pr comments

* Add remaining set of TensorPrimitives APIs for .NET 8 (#92154)

* Add remaining set of TensorPrimitives APIs for .NET 8

Adds non-vectorized implementations of:
- Max
- Min
- MaxMagnitude
- MinMagnitude
- IndexOfMax
- IndexOfMin
- IndexOfMaxMagnitude
- ConvertToHalf (only on .NET Core)
- ConvertToSingle (only on .NET Core)
- IndexOfMinMagnitude

Adds vectorized implementations of:
- Sum
- SumOfSquares
- SumOfMagnitudes
- Product
- ProductOfSums
- ProductOfDifferences

Also includes the helpers that'll make it trivial to vectorize Dot.

Beyond vectorizing the non-vectorized ones, the vectorized implementations should be improved further, including:
- Handling alignment better
- Vectorizing the remainder that doesn't fit in a vector rather than falling back to scalar

* Cleanup after previous PR, vectorize CosineSimilarity/Dot/L2Normalize/Distance, add tests

* Address PR feedback, and fix a few other issues

* Fix TensorPrimitives.CosineSimilarity to use vectorized implementations (#92204)

* Fixed duplicated code from merge.

* New Microsoft.BCL.Numerics package (#91074)

* bcl numberics library added

* bcl done

* added explicit 2.1 target

* Minor doc updates

* Apply suggestions from code review

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* fixes from PR comments

* minor csproj fixes

* fixed ref target frameworks

* minor ref csproj updates

* minor csproj updates

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

* Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource. (#91402)

* Microsoft.Bcl.Numerics.Tests: fix restore failure when DotNetBuildFromSource.

* Use NetCoreAppCurrent.

* Try fix CI test failures.

---------

Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
@radekdoulik radekdoulik mentioned this pull request Sep 20, 2023
Open
@ghost ghost locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gfoidl gfoidl gfoidl left review comments

@ericstj ericstj ericstj approved these changes

@jeffhandley jeffhandley jeffhandley approved these changes

@tannergooding tannergooding Awaiting requested review from tannergooding

@michaelgsharp michaelgsharp Awaiting requested review from michaelgsharp

Assignees

@stephentoub stephentoub

Labels
area-System.Numerics new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @jeffhandley @gfoidl @ericstj