Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some assert's errors for ARM64-LoongArch64-RISCV64. #92319

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

shushanhf
Copy link
Contributor

@shushanhf shushanhf commented Sep 20, 2023

This PR is part of the issue #69705 to amend the LA's port.

Fix some assert's errors for ARM64-LoongArch64-RISCV64.
Also fix some errors about codegen for LoongArch64-RISCV64.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 20, 2023
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

his PR is part of the issue #69705 to amend the LA's port.

Fix some assert's errors for ARM64-LoongArch64-RISCV64.
Also fix some errors about codegen for LoongArch64-RISCV64.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

Also fix some errors about codegen for LoongArch64-RISCV64.
@shushanhf
Copy link
Contributor Author

@jakobbotsch
Could you please review this PR ?
Thanks!

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failures in superpmi are the out-of-space ones we have been hitting recently.

@jakobbotsch jakobbotsch merged commit 37c10f8 into dotnet:main Sep 21, 2023
124 of 127 checks passed
@shushanhf shushanhf deleted the error_regs branch September 21, 2023 12:11
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants