-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specifying install search location options for published apphost
#42455
Conversation
… and AppHostReleativeDotNet properties
2e5cac9
to
fa9cc8d
Compare
Can you update the spec to clarify if For a relative location, is the guidance to (for example) explode a runtime tarball at a |
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Outdated
Show resolved
Hide resolved
That is probably the simplest option. I kind of intentionally didn't include an explicit/official recommendation and left the deployment side as a 'it is up to the developer to create the install layout' - until we sort out an SDK experience. |
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Gocke <andy@commentout.net>
test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAHelloWorldProject.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
See https://github.com/dotnet/designs/blob/main/proposed/apphost-embed-install-location.md.
dotnet/runtime#104749 enabled embedding install location options in
apphost
. This is the SDK side to use that ability.AppHostDotNetSearch
allows selection of which search locations should be usedapphost
if set to an invalid valueAppHostRelativeDotNet
allows specifying a relative path to the runtimeAppHostDotNetSearch=AppRelative
ifAppHostDotNetSearch
is not explicitly setapphost
onpublish
(notbuild
)cc @dotnet/appmodel @AaronRobinsonMSFT