Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specifying install search location options for published apphost #42455

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jul 30, 2024

See https://github.com/dotnet/designs/blob/main/proposed/apphost-embed-install-location.md.

dotnet/runtime#104749 enabled embedding install location options in apphost. This is the SDK side to use that ability.

  • AppHostDotNetSearch allows selection of which search locations should be used
    • Errors on creating apphost if set to an invalid value
  • AppHostRelativeDotNet allows specifying a relative path to the runtime
    • Setting implies AppHostDotNetSearch=AppRelative if AppHostDotNetSearch is not explicitly set
  • Values are only embedded in apphost on publish (not build)

cc @dotnet/appmodel @AaronRobinsonMSFT

@elinor-fung elinor-fung force-pushed the apphost-dotnet-search branch from 2e5cac9 to fa9cc8d Compare July 30, 2024 21:28
@richlander
Copy link
Member

richlander commented Jul 31, 2024

Can you update the spec to clarify if ../ style relative paths are supported and what the behavior is? That seems important to document.

https://github.com/dotnet/designs/blob/main/proposed/apphost-embed-install-location.md#app-relative-path-to-install-location

For a relative location, is the guidance to (for example) explode a runtime tarball at a .dotnet directory? I'm asking about the intended deployment side.

@elinor-fung
Copy link
Member Author

Can you update the spec to clarify if ../ style relative paths are supported and what the behavior is? That seems important to document.

https://github.com/dotnet/designs/blob/main/proposed/apphost-embed-install-location.md#app-relative-path-to-install-location

dotnet/designs#319

For a relative location, is the guidance to (for example) explode a runtime tarball at a .dotnet directory? I'm asking about the intended deployment side.

That is probably the simplest option. I kind of intentionally didn't include an explicit/official recommendation and left the deployment side as a 'it is up to the developer to create the install layout' - until we sort out an SDK experience.

Co-authored-by: Andy Gocke <andy@commentout.net>
@elinor-fung elinor-fung requested a review from agocke August 2, 2024 02:30
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@elinor-fung elinor-fung merged commit 521a00d into dotnet:main Aug 7, 2024
37 checks passed
@elinor-fung elinor-fung deleted the apphost-dotnet-search branch August 7, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Host Area-Infrastructure untriaged Request triage from a team member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants