Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing API: HttpSessionState.Mode #281

Closed
Clounea opened this issue Feb 8, 2023 · 0 comments · Fixed by #289
Closed

Add missing API: HttpSessionState.Mode #281

Clounea opened this issue Feb 8, 2023 · 0 comments · Fixed by #289
Assignees
@twsouthwick
Milestone
1.1

Comments

@Clounea
Copy link
Contributor

Clounea commented Feb 8, 2023

Summary

When I try the IHttpModule and HttpApplication in the adapter, I found that HttpSessionState.Mode is used in my module(in Sharepoint Online) but it is not supported.

Motivation and goals

HttpSessionState.Mode is used in my module(in Sharepoint Online) but it is not supported. I wonder if there is plan to support the API.

In scope

HttpSessionState.Mode

Usage example:

context.Session.Mode != SessionStateMode.Off
@joperezr joperezr added this to the 1.1 milestone Feb 8, 2023
@twsouthwick twsouthwick self-assigned this Feb 9, 2023
@twsouthwick twsouthwick mentioned this issue Feb 14, 2023
Merged
twsouthwick added a commit that referenced this issue Feb 17, 2023
@twsouthwick
Add HttpSessionState.Mode (#289)
aa73002 
This change exposes the API and sets it to `Custom`. Everything else has a meaning and implies certain behavior. This value is the only one that makes sense for us to declare. If needed, we can make it customizable later.

Fixes #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twsouthwick twsouthwick

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Add HttpSessionState.Mode dotnet/systemweb-adapters
3 participants
@twsouthwick @Clounea @joperezr